Hi,

Vlad Shakhov wrote, Monday, July 07, 2008 9:40 AM

[...]
for HOSTNAME in "" "localhost" "$(hostname)" "$(hostname -f)"; do
  if echo $DISPLAY | grep -q "^$HOSTNAME:0.*"; then
[...]
possible bashism in test.sh line 6 ($HOST(TYPE|NAME)):
  if echo $DISPLAY | grep -q "^$HOSTNAME:0.*"; then

Yes, in this case the result is a false positive.

Unfortunately, from checkbashisms's point-of-view, it's a false positive that's not currently easy to fix, given the way in which the scripts are parsed. On that basis, if you want to keep this bug open I will most likely either make it a wishlist request to support such uses, or open a new bug to do so and block this bug against it.

I'd be inclined to agree with the suggestion in #475637 that renaming the variable would stop the issue being flagged at all; even so, the script should really have been checked more closely before that report was submitted.

Regards,

Adam



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to