On Mon, Jun 23, 2008 at 10:39:12PM +0200, intrigeri wrote: > Hello, > > > Attached is a patch that adds a new "log level" which, if called by > > an action, causes the entire backup run to be halted. This is quite > > important for certain sorts of actions, such as device mounting, > > which must be able to stop the entire backup run if it fails to > > complete successfully. > > > I've given the patch some basic tests locally and it all seems to > > work like a charm, but there may be corner cases > > I haven't considered. > > Your patch seems nice, and I???m considering applying upstream. > > The only detail that troubles me is your change in src/backupninja.in, > around @@ -252,19 +259,22 @@, where you use the 'colorize' function > instead of the debug, info, etc. ones. > > Why did you this ?
Uhm, I wrote the patch six months ago. I have trouble remembering what I had for breakfast yesterday... Looking at the code, though, I suspect that if you try switching colorize back to calling the individual functions, you'll find out pretty quickly why I switched to colorize. (or desk-check the calls to fatal and halt) - Matt -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
