Bug#486937: DEB_BUILD_OPTIONS must be whitespace-separated

[Peter Samuelson]

Package: dpkg-dev
Version: 1.14.20
Severity: serious
Tags: patch

Policy 3.8.0.1, section 4.9.1, on DEB_BUILD_OPTIONS:

    If multiple flags are given, they must be separated by whitespace.

dpkg-buildpackage uses "," separators instead, which breaks any rules
file that follows the example code in Policy.

Presumably this bug is not RC for lenny, as the relevant Policy text is
new to 3.8.0.

diff -urN dpkg-1.14.20.orig/scripts/Dpkg/BuildOptions.pm 
dpkg-1.14.20/scripts/Dpkg/BuildOptions.pm
--- dpkg-1.14.20.orig/scripts/Dpkg/BuildOptions.pm      2008-06-18 
02:33:30.000000000 -0500
+++ dpkg-1.14.20/scripts/Dpkg/BuildOptions.pm   2008-06-18 23:45:52.000000000 
-0500
@@ -38,13 +38,13 @@
     $overwrite = 1 if not defined($overwrite);
 
     my $env = $overwrite ? '' : $ENV{DEB_BUILD_OPTIONS}||'';
-    if ($env) { $env .= ',' }
+    if ($env) { $env .= ' ' }
 
     while (my ($k, $v) = each %$opts) {
        if ($v) {
-           $env .= "$k=$v,";
+           $env .= "$k=$v ";
        } else {
-           $env .= "$k,";
+           $env .= "$k ";
        }
     }