severity 486046 minor
tag 486046 patch
thanks
On Thu, Jun 12, 2008 at 11:33:09PM -0500, Raphael Geissert wrote:
|| While performing an archive wide checkbashisms (from the 'devscripts'
package)
|| check I've found your package containing one or more /bin/sh scripts making
|| use of bashisms.
||
|| checkbashisms' output:
|| > possible bashism in ./usr/bin/fftw-wisdom-to-conf line 67 (unsafe echo
with
|| > backslash):
|| > echo " X($reg_nam)\\"
Since bash and dash behave the same in this case, the severity is
probably better set at minor.
Nevertheless echo behavior with \ in the arguments is not defined:
http://www.opengroup.org/onlinepubs/009695399/utilities/echo.html
The following patch should fix this by switching to printf:
diff -rud fftw3-3.1.2.orig/tools/fftw-wisdom-to-conf.in
fftw3-3.1.2/tools/fftw-wisdom-to-conf.in
--- fftw3-3.1.2.orig/tools/fftw-wisdom-to-conf.in 2006-01-05
04:04:28.000000000 +0100
+++ fftw3-3.1.2/tools/fftw-wisdom-to-conf.in 2008-06-15 17:30:18.000000000
+0200
@@ -64,7 +64,7 @@
EOF
sed 's/ *(//' | cut -d" " -f1 | grep -v -- - | egrep -v '^ *\)*$' | sort |
uniq | while read reg_nam; do
- echo " X($reg_nam)\\"
+ printf ' X(%s)\\\n' "$reg_nam"
done
cat <<EOF
Ciao. Vincent.
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
