tags 485511 +pending
thanks

Hi,

On Mon, Jun 09, 2008 at 06:40:45PM -0400, Aaron M. Ucko wrote:
> test ! -r "$CONFFILE" || . "$CONFFILE"
> 
> fails if the configuration file contains no content (as it does by
> default), as test's non-zero exit status ends up standing.

Dash considers it an error to source an empty file?  Strange...

> I'd suggest rewriting that as
> 
> if test -r "$CONFFILE"; then
>     . "$CONFFILE"
> fi

Will do.

> Anyway, once I got past that problem, I ran into another: the config
> and postinst scripts both use the bashism "function x" rather than the
> portable "x ()".

Ok, I'll change that as well.

> Could you please either fix your scripts to work under other shells
> (posh, dash)

I'll do that.

> or else explicitly run them under bash?

For things which can be fixed as easily as this?  No thanks! :-)

Thanks for reporting these issues.  I'll make a new upload soon, and
shall include them.

Thanks,
Bas

-- 
I encourage people to send encrypted e-mail (see http://www.gnupg.org).
If you have problems reading my e-mail, use a better reader.
Please send the central message of e-mails as plain text
   in the message body, not as HTML and definitely not as MS Word.
Please do not use the MS Word format for attachments either.
For more information, see http://pcbcn10.phys.rug.nl/e-mail.html

Attachment: signature.asc
Description: Digital signature

Reply via email to