Hi Kapil,

Interesting, thanks for reporting! I'll fix that up in the next upload. It's pretty hard to prevent bashisms from sneaking back in in new code when bash is still the default shell. :-(

Cheers,
Bart

Kapil Hari Paranjape wrote:
Package: acpi-support
Version: 0.109-3
Severity: important

Hello,

/etc/acpi/hibernate.sh has the contents

        #!/bin/sh

        test -f /usr/share/acpi-support/power-funcs || exit 0

        . /usr/share/acpi-support/suspendorhibernate hibernate

As far as I can see /bin/dash does not support the construct . /usr/share/acpi-support/suspendorhibernate hibernate i.e. the argument "hibernate" is not passed to the script /usr/share/acpi-support/suspendorhibernate

The script thus prints out a usage statement and just suspends the
computer instead of hibernating it.

One fix is to use
set -- hibernate just before the objectionable line.

Note that /etc/acpi/sleep.sh contains a similar line. As far as I
could tell
        egrep -rl '^\.[[:space:]]+[^[:space:]]+[[:space:]]' /etc/acpi
didn't show any other files with a similar construct.

Regards,

Kapil.

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (990, 'testing')
Architecture: i386 (i686)

Kernel: Linux 2.6.24-1-686 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages acpi-support depends on:
ii  acpi-support-base             0.109-3    scripts for handling base ACPI eve
ii  acpid                         1.0.6-9    Utilities for using ACPI power man
ii dmidecode 2.9-1 Dump Desktop Management Interface ii finger 0.17-12 user information lookup program
ii  hdparm                        8.6-1      tune hard disk parameters for high
ii  laptop-detect                 0.13.6     attempt to detect a laptop
ii  libc6                         2.7-10     GNU C Library: Shared libraries
ii  lsb-base                      3.2-11     Linux Standard Base 3.2 init scrip
ii  powermgmt-base                1.30       Common utils and configs for power
ii  vbetool                       1.0-3      run real-mode video BIOS code to a
ii  x11-xserver-utils             7.3+2      X server utilities

Versions of packages acpi-support recommends:
ii  dbus                          1.2.1-2    simple interprocess messaging syst
ii  hal                           0.5.11-1   Hardware Abstraction Layer
ii  nvclock                       0.8b3-1    Allows you to overclock your nVidi
ii  pm-utils                      1.1.0-1    utilities and scripts for power ma
ii  radeontool                    1.5-5      utility to control ATI Radeon back
ii toshset 1.73-2 Access much of the Toshiba laptop
-- no debconf information




--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to