On Thu, May 01, 2008 at 03:08:20PM +0200, Frans Pop wrote: > > Looking at grub-probe I also think we might be able to further simplify > grub-installer by calling it with a path instead of a device, but that can > wait until later. Adding a comment for that could be useful though.
Path resolution in grub-probe is expensive. If you reliably know the device, it is better if you feed it that. Otherwise it will traverse /dev to find it. The idea here is to avoid trouble derived from broken fstab (very common when installing grub from inside a chroot or so). But if you're in a controlled environment like D-I, this shouldn't be an issue. > What about the hurd_convert function in grub-installer? This should stay, it's outside the scope of grub-probe. -- Robert Millan <GPLv2> I know my rights; I want my phone call! <DRM> What good is a phone call… if you are unable to speak? (as seen on /.) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
