On Sat, May 31, 2008 at 05:13:01PM +0200, Benjamin Mesing wrote:
> tags 103820 +patch
> thanks
>
> As part of my NM process I have prepared a patch for this bug.
>
> I tracked it down to a single buggy line. The sign of a value was wrong,
> leading to an invalid (negative) array index and thus to a segfault.
> diff -Nau joe-3.5/b.c joe-3.5-modified/b.c
> --- joe-3.5/b.c 2006-07-19 02:19:05.000000000 +0200
> +++ joe-3.5-modified/b.c 2008-05-31 16:26:10.000000000 +0200
> @@ -2510,7 +2510,7 @@
> return berror = 0;
> err:
> prm(np);
> - return berror = 5;
> + return berror = -5;
> }
>
> /* Save 'size' bytes beginning at 'p' in file 's' */
Oh, good catch, thanks :) Oddly enough, the comment above bsavefd() actually
says what it should do, but when they added the comment they didn't notice
the missing minus.
--
2. That which causes joy or happiness.
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
