Bug#482143: planet: Exceptions out given seemingly valid RSS feeds (wordpress.com)

[Chris West (Faux)]

Package: planet
Version: 2.0-6
Severity: normal


Given certain RSS feed XML files, such as the (as far as I know) valid:

<?xml version="1.0" encoding="UTF-8"?>
<rss version="2.0" xmlns:media="http://search.yahoo.com/mrss/"; 
xmlns:atom="http://www.w3.org/2005/Atom";>

<channel>
    <title>Example</title>
    <link>http://example.com/</link>
    <description>foo</description>
    <pubDate>Sun, 18 May 2008 11:33:02 +0000</pubDate>
    <item>
        <guid isPermaLink="false">meta</guid>
        <title>foo</title>
        <link>http://example.com/</link>
        <pubDate>Wed, 26 Dec 2007 21:33:37 +0000</pubDate>
        <description>bar</description>
        <media:content url="http://example.com/quxx.png"; medium="image">
            <media:title type="html">baz</media:title>
        </media:content>
    </item>
    <atom:link href="http://goeswhere.com/planetfail1.xml"; rel="self" 
type="application/rss+xml" />
</channel>
</rss>

planetplanet's invocation will unexpectedly die:

ERROR:planet.runner:Update of </tmp/test.xml> failed
Traceback (most recent call last):
  File "/var/lib/python-support/python2.4/planet/__init__.py", line 245, in run
    channel.update()
  File "/var/lib/python-support/python2.4/planet/__init__.py", line 653, in 
update
    self.update_entries(info.entries)
  File "/var/lib/python-support/python2.4/planet/__init__.py", line 759, in 
update_entries
    item.update(entry)
  File "/var/lib/python-support/python2.4/planet/__init__.py", line 882, in 
update
    if item.type == 'text/html':
  File "/var/lib/python-support/python2.4/planet/feedparser.py", line 237, in 
__getattr__
    raise AttributeError, "object has no attribute '%s'" % key
AttributeError: object has no attribute 'type'

.. resulting in spam from an unhappy cron.

This happens on various real RSS feeds, for example (at the time of writing), 
http://acidcycles.wordpress.com/feed/

Ideally, for any terminal failure (which I believe this should not be), planet 
would indicate that the feed is damaged on the output page (as it does with 
web-server failures).

-- System Information:
Debian Release: 4.0
  APT prefers stable
  APT policy: (700, 'stable')
Architecture: amd64 (x86_64)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-6-xen-amd64
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)

Versions of packages planet depends on:
ii  debconf                    1.5.11etch1   Debian configuration management sy
ii  lighttpd [httpd]           1.4.13-4etch8 A fast webserver with minimal memo
ii  python                     2.4.4-2       An interactive high-level object-o
ii  python-support             0.7.7         automated rebuilding support for P

planet recommends no packages.

-- debconf information excluded



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]