Hi Jérôme,

* Jérôme SAUTRET <[EMAIL PROTECTED]> [2005-05-24 23:33]:
> I've tested your patch, it seems to work just fine (I've just
> corrected a little encoding problem). It is commited and will be included
> in the next release.

Thanks a lot!  I wasn't sure whether BINS was still maintained because
the list seemed very quiet.

By the way, I cannot see the patch in
http://kashmir.sautret.org/cgi-bin/viewcvs.cgi/bins/ ?

There is also one minor problem.  I noticed that while generating my
gallery I sometimes received this warning:

| Use of uninitialized value in gmtime at (eval 383) line 1.

The problem is buggy EXIF information, namely:

Date and Time (origi|    :  :     :  :
Date and Time (digit|2004:05:03 08:31:44

The first date is taken and this cannot be parsed.  Here's a patch:

--- /usr/bin/bins       2005-05-26 10:54:34.782363312 +0100
+++ bins        2005-05-26 10:54:19.663661704 +0100
@@ -506,7 +506,7 @@
    "date" =>
    { Name => _("Date"),
      EXIF => "DateTimeOriginal",
-     Transform => '$_ = strftime $configHash->{dateString}, gmtime str2time 
"$_" if str2time "$_"',
+     Transform => '$_ = strftime $configHash->{dateString}, gmtime str2time 
"$_"',
    # Alternatively, you could use regex substitution:
    # English version is yyyy:mm:dd hh:mm:ss to yyyy/mm/dd hh:mm:ss :
    # Transform => 's%^(\\d+):(\\d+):(\\d+) (.*)$%\$1/\$2/\$3 \$4%',


Maybe we should also check if there are multiple date EXIF entries and
go for the best one.  But I don't know what the EXIF specification
says about this.
-- 
Martin Michlmayr
http://www.cyrius.com/

Reply via email to