Package: libconfig-inetd-perl
Version: 0.25-1
Severity: minor
debian/rules includes several crufty commands. From them, the only one
I'd really flag as a problem (and not just something desirable) is
line 23 (after applying the patch to #467147 I just sent), where 'make
clean' is run but its result is ignored:
-$(MAKE) clean
The pkg-perl group's recommended practice (you can refer to
dh-make-perl's rules file for generic MakeMaker packages [1] -
although it is just a template, the '#TEST#' line gets modified) is to
replace this line with:
[ ! -f Makefile ] || $(MAKE) realclean
There are other several points worth going over in debian/rules -
i.e. if you run 'make realclean' instead of 'make clean (see
ExtUtils::MakeMaker documentation), you won't have to manually remove
Makefile and Makefile.old; dh_clean can be given the list of stamps to
remove as well; dh_installman should not need to be given blib/man3/*
when we are building with INSTALLDIRS=vendor.
[1]
http://svn.debian.org/wsvn/pkg-perl/trunk/dh-make-perl/rules.MakeMaker.noxs?op=file&rev=0&sc=0
-- System Information:
Debian Release: lenny/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.22-3-vserver-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
