severity 477954 normal thanks I'm CCing Joey who wrote the initial support for the git source package. He might want to provide his input and maybe even a patch. Release managers agreed to push changes/fixes in lenny for the new source package formats since they are not used in lenny at all.
In response to Bug#477949: On Fri, 25 Apr 2008, Goswin Brederlow wrote: > I tried using the git format to proove a point and stumbled about > this. The dpkg-source manpage says that "-i" should ignore changes in > the working directory. But it doesn't: > > dpkg-source -i -ICVS -b reprepro-3.3.2 > dpkg-source: info: using source format `3.0 (git)' > dpkg-source: error: uncommitted, not-ignored changes in working directory: > debian/changelog main.c > dpkg-buildpackage: failure: dpkg-source -i -ICVS -b reprepro-3.3.2 gave error > exit status 255 > debuild: fatal error at line 1319: > dpkg-buildpackage -rfakeroot -D -us -uc -ICVS -i failed > > Further I think the dpkg-buildpackage manpage or the error message > should include that info (-i to ignore changes) more prominently. Like > "debuild" saying to use -d to override build-depends checking. You're confused "-i" doesn't ignore all changes but only those matching a specific regular expression. If you want to ignore some specific changes, then you have to modify that regular expression... which you didn't in that example. > Last but not least I would suggest that changes are not > ignored. Instead when building source a temporary commit should be > made, packaged and removed from the working directory again. The changes are not ignored... it's a design decision to fail if there are uncommitted changes. Thus I'm closing this bug. In response to Bug#477954: On Fri, 25 Apr 2008, Mike Hommey wrote: > Severity: important Downgraded to normal as it doesn't affect any important functionnality. > A .git.tar.gz resulting from dpkg-source -b will contain a lot of stuff > that are not really or necessarily meant to be distributed: > - gitk.cache > - unpacked objects > - remotes > - stash > - ORIG_HEAD > - FETCH_HEAD > - COMMIT_EDITMSG > - config > > It would be best to eliminate most of this by first cloning the repo, > eliminate remotes, and gc --prune before creating the tarball. I have not verified this, but if it's true, then I tend to agree with Mike. It would be nice if we could improve here. For "remotes" I might disagree however, it can make sense to keep them as one might want to be able to push/pull from the remote repository used for the maintenance. Of course, usage of "git clone" makes it more difficult to preserve those... Cheers, PS: I only wanted to forward the bugs to Joey but ended up responding and even closing the first bug. Thus I should have split this mail in two... since I didn't please respond only to the relevant bug if you don't respond to both. -- Raphaël Hertzog Le best-seller français mis à jour pour Debian Etch : http://www.ouaza.com/livre/admin-debian/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
