tags 479318 + patch
thanks
Hi,
On Sun, 2008-05-04 at 11:33 +0200, Stefano Zacchiroli wrote:
> Here is what I get today, after an upgrade to perl 5.10.x, running
> lintian on a *.changes file:
>
> $ lintian ocaml-res_2.2.5-1_i386.changes
> Can't use string ("1") as an ARRAY ref while "strict refs" in use at
> /usr/share/lintian/checks/menus line 418, <IN> line 4.
> internal error: cannot run menus check on package libres-ocaml-dev
> N: Skipping check of binary package libres-ocaml-dev
The attached patch fixes the two occurrences of this problem in
checks/menus; the new version correctly pulls out all of the doc-base
issues mentioned on lintian.d.o for automake1.7 and pgf, using both perl
5.8.8 and 5.10.0.
I had a quick look and can't see any other uses of the syntax.
Regards,
Adam
Index: checks/menus
===================================================================
--- checks/menus (revision 1294)
+++ checks/menus (working copy)
@@ -415,14 +415,14 @@
my $leadsp_ok = 1; # are spaces OK?
# Intentionally skipping the first line.
- for my $idx (1 .. [EMAIL PROTECTED]) {
+ for my $idx (1 .. $#{$vals}) {
$_ = $vals->[$idx];
if (/manage\s+online\s+manuals\s.*Debian/o) {
tag "doc-base-abstract-field-is-template", "$dbfile:$line"
unless $pkg eq "doc-base";
} elsif (/^(\s+)\.(\s*)$/o and ($1 ne " " or $2)) {
tag "doc-base-abstract-field-separator-extra-whitespaces",
- "$dbfile:" . ($line - [EMAIL PROTECTED] + $idx);
+ "$dbfile:" . ($line - $#{$vals} + $idx);
} elsif (!$leadsp && /^(\s+)(\S)/o) {
# The regexp should always match.
($leadsp, $charafter) = ($1, $2);
