Hi Francesco,

it seems that your patch in 1.7-5 is not the same as the one you have given to 
gnomeradio upstream?

Patch in 1.7-5:

diff -Nur gnomeradio-1.7/src/prefs.c gnomeradio-1.7.new/src/prefs.c
--- gnomeradio-1.7/src/prefs.c  2006-11-25 12:33:57.000000000 +0100
+++ gnomeradio-1.7.new/src/prefs.c      2008-02-05 22:34:47.000000000 +0100
@@ -415,6 +415,7 @@
        
        menuitems = GTK_MENU_SHELL(tray_menu)->children;
        g_assert(mom_ps < g_list_length(menuitems));
+        mom_ps = *row;
        menuitem = g_list_nth_data(menuitems, mom_ps);
        gtk_widget_destroy(menuitem);
        menuitem = gtk_menu_item_new_with_label(ps->title);

Patch from http://bugzilla.gnome.org/attachment.cgi?id=104558:

diff -Nur gnomeradio-1.7/src/prefs.c gnomeradio-1.7.new/src/prefs.c
--- gnomeradio-1.7/src/prefs.c  2006-11-25 12:33:57.000000000 +0100
+++ gnomeradio-1.7.new/src/prefs.c      2008-02-05 23:11:32.000000000 +0100
@@ -411,7 +411,8 @@
 
        gtk_combo_box_remove_text(GTK_COMBO_BOX(preset_combo), *row + 1);
        gtk_combo_box_insert_text(GTK_COMBO_BOX(preset_combo), *row + 1, 
ps->title);
-       preset_combo_set_item(mom_ps);
+        mom_ps = *row;
+        preset_combo_set_item(mom_ps);
        
        menuitems = GTK_MENU_SHELL(tray_menu)->children;
        g_assert(mom_ps < g_list_length(menuitems));

The former doesn't seem to be working but the latter does indeed fix the 
crash.

Cesare



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to