On Sun, Apr 27, 2008 at 05:37:10AM +0200, Gregory Colpart wrote:
> Hello,
> 
> Thanks for your report.
> 
> On Sat, Mar 29, 2008 at 02:13:28AM +0900, Osamu Aoki wrote:
> > Package: pppoeconf
> > [...]
> > Problems:
> > pppoeconf created /etc/network/interface:
> >  * does not disable dhcp if it exists
> 
> Yes, pppoeconf doesn't disable precedent configurations.
> It's not so easy to disable a configuration in /e/n/i then don't
> hesitate if you have idea/patch to deal correctly with that.

Two ideas:
 * Do not try to retain original configuration.
 * Keep your logic as is while warning user.

> >  * uses virtual interface name after auto
> >  * may create both ppp and manual configuration
> 
> It's how pppoeconf works for now. It could probably be improved
> (see below my comments about your "Option 1").
> 
> 
> >  * may have both "auto eth0" and "allow-hotplug eth0"
> 
> Yes, I corrected it:
> http://git.debian.org/?p=collab-maint/pppoeconf.git;a=commitdiff;h=03bc0714f84dceb5ffcb1898133e3845a2655760

Yes.

> > I expect simple pppoe connection should have one of the following as
> > /etc/network/interfaces:
> > 
> > Option 1: (I think this is best)
> > |auto lo
> > |iface lo inet loopback
> > |
> > |auto eth0
> > |iface eth0 inet ppp
> > |pre-up    /sbin/ifconfig eth0 up
> > |post-down /sbin/ifconfig eth0 down
> > |# create ppp0 interface which connects via eth0 connection
> > |provider dsl-provider
> 
> I agree that it could be the best /e/n/i. 
> Before changing it, I must ensure:
> - to have a perfect transition from etch and from sarge,
> - to have a valid comportement with kernel_pppoe =1 and =0,
> - not to have conflicts with current network configuration (your
>   proposition uses eth0 for PPPoE interface, but it's not easy to
>   disable current eth0 configuration as I said above).

If you want to do this, adding warinig when finding current eth0
configuration in /e/n/i.

> I'm waiting your comments before hacking...

I personally think, it is best comment out current  /e/n/i contents as
comment and add fresh pppoe only configuration.  Whoever mkes any more
complicated configuration should know how to edit it. (Possibly with
message displayed to the user.)  

We need to rotect newbie hitting problem.

Osamu




-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to