tags 476108 + fixed-upstream patch thanks On 2008-04-14 17:32 +0200, Sven Joachim wrote:
> On 2008-04-14 16:33 +0200, Michael Berg wrote: >> I found the following online: >> http://lists.gnu.org/archive/html/bug-gnu-emacs/2008-03/msg00135.html >> http://www.nabble.com/C-x-C-w-fails-under-VC-td16083952.html >> with no follow-up yet. > > Too bad. It seems that upstream's bug handling has declined since RMS > is no longer tracking every bug personally. It turns out that this is actually not the case, on the contrary. :-) The Emacs developers now have their own bug tracking system based on debbugs (Debian's BTS) at http://emacsbugs.donarmstrong.com/, and you can find the two reports there under http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=94 and http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=60. For the first one, there is a patch at http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=94#10 that fixes the problem. Here is the diff that's actually installed upstream (seems to be identical): --8<---------------cut here---------------start------------->8--- diff -u -r1.424.2.12 -r1.424.2.13 --- vc.el 1 Feb 2008 05:49:49 -0000 1.424.2.12 +++ vc.el 29 Mar 2008 19:37:56 -0000 1.424.2.13 @@ -1047,9 +1047,14 @@ (when (and (not (eq t okstatus)) (or (not (integerp status)) (and okstatus (< okstatus status)))) - (pop-to-buffer (current-buffer)) - (goto-char (point-min)) - (shrink-window-if-larger-than-buffer) + ;; Don't show internal temp buffers. Especially since, together + ;; with with-temp-buffer and pop-up-frames, this can result in + ;; bugs where with-temp-buffer ends up not preserving + ;; current-buffer (because kill-buffer doesn't preserve it). + (unless (eq ?\s (aref (buffer-name (current-buffer)) 0)) + (pop-to-buffer (current-buffer)) + (goto-char (point-min)) + (shrink-window-if-larger-than-buffer)) (error "Running %s...FAILED (%s)" command (if (integerp status) (format "status %d" status) status)))) (if vc-command-messages --8<---------------cut here---------------end--------------->8--- Corresponding Changelog entry: 2008-03-29 Stefan Monnier <[EMAIL PROTECTED]> * vc.el (vc-do-command): Don't show internal temp buffers. I've created a small monotone test repository and verified that the patch does indeed fix the problem. Cheers, Sven -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
