tags 465635 + patch
thanks

On 14/02/08 at 01:44 +0100, Danai SAE-HAN (韓達耐) wrote:
> Op 13-02-08 17:18, schreef Lucas Nussbaum:
> > 
> > During a rebuild of all packages in sid, your package failed to build on 
> > i386.
> > 
> > Seems that the parallel build stuff still has problems...
> 
> Doh!  Thanks for running this package again on your grid.  I'm so honoured!

Well, I introduced that bug myself. ;)

Here is a patch that fixes it. The problem is there's a race condition
in your makefile, with the ordering of pre-clean and clean-$font when
running make with -j.

If you don't want to spend hours rebuilding the package, I could do
that and upload the NMU, if you want.
-- 
| Lucas Nussbaum
| [EMAIL PROTECTED]   http://www.lucas-nussbaum.net/ |
| jabber: [EMAIL PROTECTED]             GPG: 1024D/023B3F4F |
diff -Nru latex-cjk-chinese-arphic-1.18/debian/changelog latex-cjk-chinese-arphic-1.18+nmu1/debian/changelog
--- latex-cjk-chinese-arphic-1.18/debian/changelog	2008-01-30 11:49:47.000000000 +0100
+++ latex-cjk-chinese-arphic-1.18+nmu1/debian/changelog	2008-04-13 19:11:56.000000000 +0200
@@ -1,3 +1,11 @@
+latex-cjk-chinese-arphic (1.18+nmu1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Fix problem in the $(clean_fonts) rule when running debian/rules clean
+    with -j: some debian/control entries could be missing. Closes: #465635.
+
+ -- Lucas Nussbaum <[EMAIL PROTECTED]>  Sun, 13 Apr 2008 19:09:51 +0200
+
 latex-cjk-chinese-arphic (1.18) unstable; urgency=low
 
   * The "I love vertical writing" release.
diff -Nru /tmp/Q5MajWlUok/latex-cjk-chinese-arphic-1.18/debian/rules /tmp/K9L68qsopH/latex-cjk-chinese-arphic-1.18+nmu1/debian/rules
--- latex-cjk-chinese-arphic-1.18/debian/rules	2008-01-30 11:50:37.000000000 +0100
+++ latex-cjk-chinese-arphic-1.18+nmu1/debian/rules	2008-04-13 19:14:10.000000000 +0200
@@ -198,7 +198,9 @@
 
 	touch $@
 
-clean: pre-clean $(clean_fonts)
+clean: $(clean_fonts)
+	cat debian/control.stem.in debian/control.font.* > debian/control
+	rm debian/control.font.*
 	dh_testdir debian/font.fd.in debian/latex-cjk/subfonts.pe
 	dh_testroot
 	rm -f build-stamp
@@ -206,17 +208,16 @@
 	dh_clean 
 	rm -rf build/
 
-pre-clean:
-	cd debian && cp control.stem.in control
-
 $(clean_fonts): abbrev = $(patsubst clean_%,%,$@)
 $(clean_fonts): MY_DH_OPTIONS = -p$(bin-package) -P$(d)
-$(clean_fonts):
-	@cd debian && \
+$(clean_fonts): 
+	# there was a possible race condition here when running with make -j,
+	# with >> control. We append to seperate files instead.
+	cd debian && \
 	    sed -e 's/@TYPEFACE@/$(typeface)/g' \
 		-e 's/@FAMILYNAME@/$(familyname)/g' \
-		control.leaf.in >> control
-	@cd debian && \
+		control.leaf.in >> control.font.$(bin-package)
+	cd debian && \
 	    sed -e 's/@ABBREV@/$(abbrev)/g' \
 		-e 's/@FAMILYNAME@/$(familyname)/g' \
 		-e 's/@TYPEFACE@/$(typeface)/g' \
@@ -269,4 +270,4 @@
 
 binary: binary-indep binary-arch
 .PHONY: build clean binary-indep binary-arch binary install \
-	$(fonts) $(install_fonts) $(binary_fonts) $(clean_fonts) pre-clean
+	$(fonts) $(install_fonts) $(binary_fonts) $(clean_fonts)

Attachment: signature.asc
Description: Digital signature

Reply via email to