Junichi Uekawa wrote:
Hi,

I was thinking over this code this weekend, and I am worried about this one 
case:

1. user install pbuilder, lets pbuilder overwrite the config
2. user finds that auto-detected value doesn't work (it didn't have the right 
arch, etc.)
 and modifies /etc/pbuilderrc

3. user upgrades pbuilder

I have a gut feeling that pbuilder won't ask if it should overwrite
the config file in 3, and the user is going to end up with a broken
config.

What do you think?
No, by default, an existing pbuilderrc generates "don't overwrite config" 
behaviour.

If the user fixes the pbuilderrc file, on upgrade his modification will be 
preserved.

I might have been unclear:
If the user has once answered 'Yes' to the question "Overwrite
config", if the user fixes the pbuilderrc file, will the user be
prompted by the question again or will pbuilder silently rewrite the
file on upgrade?

The default debconf level is medium. By default, the question about rewrite is asked at low prio. and *always* defaults to no. So, no, there will be NO silent rewrite:

Here is the code that makes sure of this:

[..]
                db_get pbuilder/rewrite
                [ "$RET" = "true" ] || exit 0

                # make sure latter calls do not overwrite stuff silently
                db_set pbuilder/rewrite "false"
[..]

--
Regards,
EddyP
=============================================
"Imagination is more important than knowledge" A.Einstein



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to