Package: xmltv-util
Version: 0.5.51-2
Severity: normal

If remote files aren't available then the error from tv_grab_uk_rt
isn't very helpful.  e.g.:

  Use of uninitialized value in concatenation (.) or string at 
/usr/bin/tv_grab_uk_rt line 
567.

The small patch attached detects when the GET fails and dies indicating
the failing URI.

regards,
mark

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.23.9
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) (ignored: LC_ALL 
set to en_GB.UTF-8)

Versions of packages xmltv-util depends on:
ii  libarchive-zip-perl           1.16-1     Module for manipulation of ZIP arc
ii  libcompress-zlib-perl         1.41-1     Perl module for creation and manip
ii  libdate-manip-perl            5.44-3     a perl library for manipulating da
ii  libhtml-parser-perl           3.55-1     A collection of modules that parse
ii  libhtml-tableextract-perl     2.07-0.1   Perl module that simplifies extrac
ii  libhtml-tree-perl             3.19.01-2  represent and create HTML syntax t
ii  libhttp-cache-transparent-per 1.0-1      Perl module used to transparently 
ii  libio-stringy-perl            2.110-1    Perl5 modules for IO from scalars 
ii  libsoap-lite-perl             0.68-1     Client and server side SOAP implem
ii  libterm-readkey-perl          2.30-3     A perl module for simple terminal 
ii  libtext-bidi-perl             0.03-2     Text::Bidi - Unicode bidi algorith
ii  libwww-mechanize-perl         1.18-1     Automate interaction with websites
ii  libwww-perl                   5.805-1    WWW client/server library for Perl
ii  libxml-libxml-perl            1.58-3     Perl module for using the GNOME li
ii  libxml-parser-perl            2.34-4     Perl module for parsing XML files
ii  libxml-twig-perl              1:3.25-1   Perl module for processing huge XM
ii  libxml-writer-perl            0.600-3    Perl module for writing XML docume
ii  libxmltv-perl                 0.5.51-2   Perl libraries related to the XMLT
ii  perl                          5.8.8-12   Larry Wall's Practical Extraction 
ii  perl-modules                  5.8.8-12   Core Perl modules

Versions of packages xmltv-util recommends:
pn  liblingua-preferred-perl      <none>     (no description available)
pn  libterm-progressbar-perl      <none>     (no description available)
pn  libtext-kakasi-perl           <none>     (no description available)
pn  libunicode-string-perl        <none>     (no description available)

-- no debconf information
--- /usr/bin/tv_grab_uk_rt      2008-03-24 12:04:00.000000000 +0000
+++ /usr/bin/tv_grab_uk_rt.new  2008-03-24 12:05:35.000000000 +0000
@@ -470,6 +470,9 @@
 my (%channels, %seen_rt_id, %seen_name);
 say( "Retrieving list of available channels from Radio Times" ) if $opt_debug;
 my $rt_channels_dat = get $rt_channels_uri;
+unless( $rt_channels_dat ) {
+    die "Couldn't fetch the available channels data from $rt_channels_uri"; 
+}
 say( "Converting list of available channels from UTF-8 to ISO-8859-1\n" ) if 
$opt_debug;
 Encode::from_to( $rt_channels_dat, "utf-8", "iso-8859-1" );
 my @rt_channels = split /\n/, $rt_channels_dat;
@@ -752,6 +755,9 @@
     local $SIG{__WARN__} = sub { warn "$uri: $_[0]" };
     say( "\nRetrieving listings file for '$rt_name' ($uri)" ) if $opt_debug;
     my $page = get $uri;
+    unless( $page ) {
+        die "Couldn't fetch listings from $uri";
+    }
     say( "Converting listings file for '$rt_name' from UTF-8 to ISO-8859-1" ) 
if $opt_debug;
     Encode::from_to( $page , "utf-8" , "iso-8859-1");
 

Reply via email to