Package: e16
Version: 0.16.8.10.dfsg.1-1
Severity: wishlist
When setting the background with "Desktop Background Setting" in the menu
which appears when I do right-click while the mouse pointer is in the root
window, if I choose "keep aspect on scale", e16 forces the slider at
the bottom of the preview window to have the same value as the right
slider. This means e16 sets the scaling ratio of the image only with
the right slider and ignores the bottom slider. It is inconvenient:
* if the image is long, the image can't be scaled large enough so that
it covers the whole monitor
* if the image is wide, it is difficult to scale the image so that
the scaled image has exactly the same width as the monitor
I suggest the attached patch.
-- System Information:
Debian Release: lenny/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.21
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) (ignored: LC_ALL set to C)
Versions of packages e16 depends on:
ii e16-data 0.16.8.10.dfsg.1-1 e16 window manager support files
ii libaudiofile0 0.2.6-6 Open-source version of SGI's audio
hi libc6 2.7-4 GNU C Library: Shared libraries
ii libesd0 0.2.35-2 Enlightened Sound Daemon - Shared
ii libglib2.0-0 2.14.2-1 The GLib library of C routines
ii libice6 1:1.0.1-2 X11 Inter-Client Exchange library
ii libimlib2 1.4.0-1 powerful image loading and renderi
ii libpango1.0-0 1.18.4-1 Layout and rendering of internatio
ii libsm6 1:1.0.1-3 X11 Session Management library
ii libx11-6 2:1.0.3-5 X11 client-side library
ii libxcomposite1 1:0.3.2-1+b1 X11 Composite extension library
ii libxdamage1 1:1.1.1-3 X11 damaged region extension libra
ii libxext6 1:1.0.1-2 X11 miscellaneous extension librar
ii libxfixes3 1:4.0.1-5 X11 miscellaneous 'fixes' extensio
ii libxft2 2.1.8.2-8 FreeType-based font drawing librar
ii libxinerama1 1:1.0.1-4.1 X11 Xinerama extension library
ii libxrandr2 2:1.2.1-1 X11 RandR extension library
ii libxrender1 1:0.9.2-1 X Rendering Extension client libra
ii libxxf86vm1 1:1.0.1-2 X11 XFree86 video mode extension l
-- no debconf information
diff -u -rN e16-0.16.8.10.dfsg.1-unmodified/src/backgrounds.c
e16-0.16.8.10.dfsg.1/src/backgrounds.c
--- e16-0.16.8.10.dfsg.1-unmodified/src/backgrounds.c 2008-03-18
20:29:15.000000000 +0900
+++ e16-0.16.8.10.dfsg.1/src/backgrounds.c 2008-03-18 23:36:58.000000000
+0900
@@ -495,8 +495,6 @@
EImageGetSize(bgp->im, &iw, &ih);
- if (bgp->keep_aspect)
- bgp->xperc = bgp->yperc;
if (bgp->xperc > 0)
w = (rw * bgp->xperc) >> 10;
