On Sat, 2005-05-14 at 12:40 +0200, Javier FernÃndez-Sanguino PeÃa wrote:
> On Tue, May 10, 2005 at 10:27:25AM -0400, James D Strandboge wrote:
> > Package: tiger
> > Version: 1:3.2.1-24
> > Severity: normal
> > 
> > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=288086
> > 
> > discusses the issue, but looking at the code reveals:
> > $PS -eo pid,user,state,fname,command,args |
> > 
> > This should be:
> > $PS -eo pid,user,state,comm,command,args |
> > 
> > otherwise commnds with name greater than 8 characters still aren't
> > properly found.
> 
> Sorry, but your assessment is not correct. command == comm and if you check 
> the code:
> 
> [ "$proc" = "$comm" ] || [ "$proc" = "$fname" ] && [ "$state" != "T" ] && [ 
> "$state" != "Z" ] && found="yes"
> 
> So we check both by the command name and the full name. Notice that:
> 
> 1- fname refers to the binary file being run
> 2- command might refer to the binary file being run with full path OR to 
> whatever the program renames itself.
> 
> So, even if fname is trimmed to 8 chars, there are some programs that will 
> modify 'command' at will and cannot be checked properly. The code is there 
> so that the admin can check against both.
> 
> I'm closing this bug.

Hmmm, the problem is checking for 'rcp.mountd' does not work.  I don't
think that comm and command are the same, as using both results in
different output in each column.  If you are going to stick with fname,
then it should be documented that tiger may not recognize your command,
or use all three.

Jamie


Reply via email to