Hi Justin On Sun, Mar 09, 2008 at 05:42:40PM +0000, Justin B Rye wrote: > Package: cron-apt > Version: 0.4.14 > Followup-For: Bug #467616 > Tags: patch > > (Butting in on cstandbridge's wishlist, since I'd just noticed it > myself) > > Ola Lundqvist wrote: > > Thanks for the report. I can not recall either adding nor removing > > any logrotate config for this package. > > > > Which file is it that you want rotated? > > cron-apt creates /var/log/cron-apt/log; on my own Stable desktop > system, with a default config, that file has reached 269K. Not > exactly a DoS, but it's not how logs are meant to work, and it does > seem to be a packaging error. > > The src/Makefile has the following lines: > > # Logrotate > mkdir -p $(DESTDIR)$(LOGROTDIR) > cp src/logrotate $(DESTDIR)$(LOGROTDIR)/cron-apt > > But that gives an error: > > cp: cannot stat `src/logrotate': No such file or directory
Oh! > The file exists, it's just looking in the wrong place; take out the > "src/" and everything works. Minimalist patch attached. Thanks! That was a simple fix. > CAVEATS: I Am Not A Programmer, and this is almost certainly not the > "right" way to fix cron-apt. I suspect the "right" way would > involve activating the "#dh_installlogrotate" line in the rules > file, but then you'd need a logrotate file in debian/, not src/. Likely so. > > root.adm file ownership could be managed, but it is not trivial. > > That would presumably require the Makefile process that creates the > logdir also to do something like > > install -g adm -m 0640 /dev/null $(DESTDIR)$(LOGDIR)/log > > which looks pretty trivial to me, but my patch only takes it as far > as fixing the build error. No it is not that trivial. The reason is that the log file is not created by the package. It is only created in certain configurations by cron-apt itself. That means that cron-apt have to change the access permissions on creation which is non-trivial. I do not say it is hard bt it is not trivial. I hope logrotate handles that for me. :) Best regards, // Ola > -- > JBR > Ankh kak! (Ancient Egyptian blessing) -- --------------------- Ola Lundqvist --------------------------- / [EMAIL PROTECTED] Annebergsslingan 37 \ | [EMAIL PROTECTED] 654 65 KARLSTAD | | http://opalsys.net/ +46 (0)70-332 1551 | \ gpg/f.p.: 7090 A92B 18FE 7994 0C36 4FE4 18A1 B1CF 0FE5 3DD9 / --------------------------------------------------------------- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
