Package:  boxbackup-server boxbackup-client
Version:  0.10-1
Severity: important
Tags:     patch
User:     [EMAIL PROTECTED]
Usertags: incorrect-dependency

I just checked the shutdown order in unstable on a machine with
dependency based boot sequencing enabled, and discovered a problem
with the init.d scripts provided in boxbackup-server and
boxbackup-client.  Both start to early, because both need a mounted
/usr/ but do not depend on $remote_fs.  Both also need to stop before
sendsigs, and thus need a stop dependency on $remote_fs too.  In
addition, both get stop symlinks in rcS.d/, which never make sense as
that directory is only used during boot and never when switching
runlevels.  Last, both scripts provide the same facility, making
package installation fail when trying to install both.

Here is a patch to solve these issues.

diff -ur boxbackup-0.10+really0.10.orig/debian/boxbackup-client.init 
boxbackup-0.10+really0.10/debian/boxbackup-client.init
--- boxbackup-0.10+really0.10.orig/debian/boxbackup-client.init 2008-03-08 
21:37:44.000000000 +0100
+++ boxbackup-0.10+really0.10/debian/boxbackup-client.init      2008-03-08 
23:03:24.000000000 +0100
@@ -1,11 +1,11 @@
 #! /bin/sh
 #
 ### BEGIN INIT INFO
-# Provides: boxbackup-server
-# Required-Start:  $syslog $local_fs $network
-# Required-Stop: $syslog $local_fs $network
+# Provides: boxbackup-client
+# Required-Start:  $syslog $remote_fs $network
+# Required-Stop: $syslog $remote_fs $network
 # Default-Start: 2 3 4 5
-# Default-Stop: S 0 1 6
+# Default-Stop: 0 1 6
 # Short-Description: boxbackup client
 # Description: Init script to start and stop the boxbackup client
 ### END INIT INFO
Only in boxbackup-0.10+really0.10/debian: boxbackup-client.init.~1~
Only in boxbackup-0.10+really0.10/debian: boxbackup-client.init.~2~
diff -ur boxbackup-0.10+really0.10.orig/debian/boxbackup-server.init 
boxbackup-0.10+really0.10/debian/boxbackup-server.init
--- boxbackup-0.10+really0.10.orig/debian/boxbackup-server.init 2008-03-08 
21:37:44.000000000 +0100
+++ boxbackup-0.10+really0.10/debian/boxbackup-server.init      2008-03-08 
23:03:11.000000000 +0100
@@ -2,10 +2,10 @@
 #
 ### BEGIN INIT INFO
 # Provides: boxbackup-server
-# Required-Start:  $syslog $local_fs $network
-# Required-Stop: $syslog $local_fs $network
+# Required-Start:  $syslog $remote_fs $network
+# Required-Stop: $syslog $remote_fs $network
 # Default-Start: 2 3 4 5
-# Default-Stop: S 0 1 6
+# Default-Stop: 0 1 6
 # Short-Description: boxbackup server
 # Description: Init script to start and stop the boxbackup server
 ### END INIT INFO

As the stop script do not seem to do much except killing the daemon,
that task might be better left to the sendsigs script in runlevel 0
and 6, to speed up shutdown.  If this is indeed the case, I recommend
removing 0 and 6 from the Default-Stop list.

Happy hacking,
--
Petter Reinholdtsen



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to