Gerrit Pape wrote:
> On Sun, Feb 10, 2008 at 03:47:44PM -0800, Josh Triplett wrote:
>> git-cherry-pick uses the user running git-cherry-pick as the author
>> and committer.  At a minimum, it should preserve the original author.
> 
> Hi Josh, it does so for me
> 
>  mkdir repo && cd repo && git init
>  echo foo >foo && git add foo && git commit -mfoo
>  git checkout -b b
>  echo bar >bar && git add bar
>  GIT_AUTHOR_NAME=foo [EMAIL PROTECTED] git commit -mbar
>  git checkout master
>  echo baz >baz && git add baz && git commit -m baz
>  git cherry-pick b
> 
>  git show --pretty=full
> 
> The last command prints:
> ---
> commit 7f954f36b7a73cc94ad4ba5a3fc4621a2449d392
> Author: foo <[EMAIL PROTECTED]>
> Commit: Gerrit Pape <[EMAIL PROTECTED]>
> 
>     bar
> 
> diff --git a/bar b/bar
> new file mode 100644
> index 0000000..5716ca5
> --- /dev/null
> +++ b/bar
> @@ -0,0 +1 @@
> +bar
> ---
> 
> Checked 1.5.4.1 and 1.5.4.3.  Do you have a testcase?

Hmmm.  I remember observing behavior that contradicted this example,
with the cherry-picked commit using me as the author and committer,
but I don't have a test case right now, and I can't seem to reproduce
this bug anymore.  I'll reopen if I recreate it.

- Josh Triplett

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to