Package: vzctl
Version: 3.0.22-4
Severity: normal

The following modification made by the Debian package is wrong twice:

--- vzctl-3.0.22.orig/scripts/vps-functions.in
+++ vzctl-3.0.22/scripts/vps-functions.in
@@ -143,6 +143,10 @@
        local dev
 
        for dev in $(vz_get_neighbour_devs "$2"); do
+               if [ $(cat /proc/sys/net/ipv4/conf/$dev/proxy_arp) == 0 ] && [ 
"$1" -
eq "add" ] ; then
+                   vzwarning "Function proxy_arp for $dev is set to 0. Enable 
with '
sysctl -w net.ipv4.conf.$dev.proxy_arp=1'. See 
/usr/share/doc/vzctl/README.Debian."
+               fi
+
                ${IP_CMD} neigh "$1" proxy "$2" dev "$dev" >/dev/null 2>&1
        done
 }

=> -eq is for numerical comparison and comparing to "add" is bound to fail:
/usr/lib/vzctl/scripts/vps-functions: line 146: [: add: integer expression 
expected

Just use [ "$1" = "add" ]. 

Likewise "==" is a bashism, you shouldn't use it. And you need to protect the 
$(cat ...) in case it returns an empty value. The correct check is thus:
[ "$(cat /proc/sys/net/ipv4/conf/$dev/proxy_arp)" = "0" ]


And the README.Debian states:

+Network configuration:
+----------------------
+
+If you want network access for the virtual server then you need to
+enable IP forwarding. You do that in the /etc/network/options file
+using the directive.
+
+  ip_forward=yes

=> this is obsolete nowadays, we recommend usage of /etc/sysctl.conf and
net.ipv4.conf.default.forwarding=1


-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 
'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.24-1-686 (SMP w/1 CPU core)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages vzctl depends on:
ii  iproute                       20080108-1 Professional tools to control the 
ii  libc6                         2.7-9      GNU C Library: Shared libraries
ii  vzquota                       3.0.11-1   server virtualization solution - q

Versions of packages vzctl recommends:
ii  rsync                         2.6.9-6    fast remote file copy program (lik

-- no debconf information



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to