Package: hsqldb-server
Version: 1.8.0.7-1etch1

There are some errors in the init-script regarding stop, restart and status.


/etc/init.d/hsqldb-server status
will always report NOT RUNNING, because the is_running function is called without type as arg.


/etc/init.d/hsqldb-server stop
will always report about stopping a server type even if it is not running

/etc/init.d/hsqldb-server restart will always try to start each type, regardless of the state of is_configured and therefor create a pid-file even if it is not running


patch see attachement ...


# diff -Naur hsqldb-server.orig hsqldb-server.new
--- hsqldb-server.orig  2007-11-28 23:59:00.000000000 +0100
+++ hsqldb-server.new   2008-02-18 17:47:25.000000000 +0100
@@ -126,15 +126,14 @@
        status=0
        log_daemon_msg "Stopping HSQLDB database server"
        for type in server webserver; do
-               d_stop $type && log_progress_msg "$type"
-               status=$(($status || $?))
+ is_running $type && d_stop $type && log_progress_msg "$type" && status=$(($status || $?))
        done
        log_end_msg $status
        ;;
     status)
        status=0
        for type in server webserver; do
-               is_running
+               is_running $type
                typestatus=$?
                if [ $typestatus -eq 0 ]; then
                        log_success_msg "HSQLDB $type is running."
@@ -149,7 +148,7 @@
        status=0
        log_daemon_msg "Restarting HSQLDB database server"
        for type in server webserver; do
-               d_stop $type && sleep 1 && d_start $type
+ d_stop $type && sleep 1 && is_configured $type && d_start $type
                status=$(($status || $?))
                log_progress_msg $type
        done



Best regards
Klaus Zerwes zero-sys.net
--- hsqldb-server.orig  2007-11-28 23:59:00.000000000 +0100
+++ hsqldb-server.new   2008-02-18 17:47:25.000000000 +0100
@@ -126,15 +126,14 @@
        status=0
        log_daemon_msg "Stopping HSQLDB database server"
        for type in server webserver; do
-               d_stop $type && log_progress_msg "$type"
-               status=$(($status || $?))
+               is_running $type && d_stop $type && log_progress_msg "$type" && 
status=$(($status || $?))
        done
        log_end_msg $status
        ;;
     status)
        status=0
        for type in server webserver; do
-               is_running
+               is_running $type
                typestatus=$?
                if [ $typestatus -eq 0 ]; then
                        log_success_msg "HSQLDB $type is running."
@@ -149,7 +148,7 @@
        status=0
        log_daemon_msg "Restarting HSQLDB database server"
        for type in server webserver; do
-               d_stop $type && sleep 1 && d_start $type
+               d_stop $type && sleep 1 && is_configured $type && d_start $type
                status=$(($status || $?))
                log_progress_msg $type
        done

Reply via email to