tags 445399 - patch thanks
Sorry, but the patch is _buggy_ for most parts. > diff -u musiclibrarian-1.6/debian/menu musiclibrarian-1.6/debian/menu > --- musiclibrarian-1.6/debian/menu > +++ musiclibrarian-1.6/debian/menu > @@ -1,2 +1,2 @@ > -?package(musiclibrarian):needs="X11" section="Apps/Sound"\ > +?package(musiclibrarian):needs="X11" section="Applications/Sound"\ > title="Music Librarian" command="/usr/bin/music-librarian" This is ok. > diff -u musiclibrarian-1.6/debian/control musiclibrarian-1.6/debian/control > --- musiclibrarian-1.6/debian/control > +++ musiclibrarian-1.6/debian/control > @@ -5,22 +5,20 @@ > -Build-Depends: debhelper (>= 5.0.37.2), python-central (>= 0.5) > -Build-Depends-Indep: debhelper (>= 5.0.37.2), python-central (>= 0.5), > python (>= 2.3.0), python-dev (>= 2.3.0) > -Standards-Version: 3.6.0 > +Build-Depends: debhelper (>= 5.0.38) > +Build-Depends-Indep: python-central (>= 0.5.6), python-all-dev (>= 2.3.5-11) why python-all-dev? Is there a c module to compile? the right fix would be to drop python-dev. Also you need at least python in build-depends, as you need it for the clean target (if you'd run setup.py clean in there, which is the proper way....) > +Standards-Version: 3.7.3 > +XS-Python-Version: all > +Homepage: http://alioth.debian.org/projects/musiclibrarian > > Package: musiclibrarian > Architecture: all > Depends: ${python:Depends}, python-gtk2 (>= 2.4.0), python-glade2, > python-pyvorbis, python-id3, python-pyao, python-pymad, libglade2-0 (>= > 1:2.4.1) > -XS-Python-Version: current > XB-Python-Version: ${python:Versions} ... should be installed for the current version only, and modules moved into a private module dir imho (see below). > Description: A simple GUI tool to organize collections of music > Music Librarian is a tool to assist you in organizing your collection > - of music files. It provides an interface from which you can view the > + of music files. It provides an interface from which you can view the > list of files in your collection and modify the tags of one or more > files. > . > Music Librarian handles ogg files natively, but also has support for > - the legacy mp3 format. It displays music in a hierarchical > + the legacy mp3 format. It displays music in a hierarchical > organization according to one of several rules, and allows you to > undo any number of changes to files. > - . > - The upstream Web site of Music Librarian is > - http://alioth.debian.org/projects/musiclibrarian. That's ok. > \ No newline at end of file > diff -u musiclibrarian-1.6/debian/rules musiclibrarian-1.6/debian/rules > --- musiclibrarian-1.6/debian/rules > +++ musiclibrarian-1.6/debian/rules > @@ -6,29 +6,35 @@ > # Uncomment this to turn on verbose mode. > #export DH_VERBOSE=1 > > +PYVERS=$(shell pyversions -vr) > + Why!? For private modules? > CFLAGS = -Wall -g > > clean: > dh_testdir > dh_testroot > - rm -f build-stamp configure-stamp > + -rm -rf build Where's the sense of the - at the begin? man rm. You should run setup.py clean and search for *.pyc and remove the files, in case setup.py leaves them sitting around. > + rm -f build-stamp configure-stamp install-stamp > > dh_clean > > # Nothing to do to build the package. > build: > > -install: > +install: install-stamp > +install-stamp: $(PYVERS:%=install-python-%) > + touch $@ > + > + sed -i -e '1s/python.*/python/' > $(CURDIR)/debian/musiclibrarian/usr/bin/music-librarian Did you think about that? It will be called for all python versions you build for (which doesn't make sense anyway...). It should not even be necessary if you build it with the default python version. > + > +install-python-%: > dh_testdir > dh_testroot > - dh_clean -k > - dh_installdirs > > - ./setup.py install --no-compile > --prefix=$(CURDIR)/debian/musiclibrarian/usr > + python$* ./setup.py install --no-compile > --prefix=$(CURDIR)/debian/musiclibrarian/usr Again, runnign setup once with python is enough. Better fix the package to use a private modules dir like /usr/share/musiclibrarian only. pycentral will handle that... > > binary-indep: install > dh_testdir > - dh_installdirs > dh_testroot > dh_installchangelogs > dh_installdocs > @@ -39,7 +45,7 @@ > dh_compress > dh_fixperms > dh_pycentral > - dh_python /usr/share/musiclibrarian Right. > + rmdir $(CURDIR)/debian/musiclibrarian/usr/lib This will FTBFS as soon as pycentral is fixed. > dh_installdeb > dh_shlibdeps > dh_gencontrol [....] Please fix your patch. Thanks, Bernd -- Bernd Zeimetz <[EMAIL PROTECTED]> <http://bzed.de/> -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
