> On Sun, Feb 17, 2008 at 03:04:21PM +0100, Frank Lichtenheld wrote:
> > On Sun, Feb 17, 2008 at 12:39:05AM +0600, Sikon wrote:
> > > In debian/rules, version 0.99.10 is incorrectly passed to pod2man. This
> > > should be bumped to 0.99.12.
> > >
> > > Even better, use dpkg-parsechangelog to extract the version instead of
> > > hardcoding it! :)
> >
> > I actually like the fact that this documents when I've last verified
> > that the manpage is accurate.
>
> And to find bugs like this:
> diff -urNad trunk~/src/prefs.c trunk/src/prefs.c
> --- trunk~/src/prefs.c        2008-02-17 15:36:26.000000000 +0100
> +++ trunk/src/prefs.c 2008-02-17 15:37:15.000000000 +0100
> @@ -360,8 +360,6 @@
>    locale_fprintf(fp, _("  --hash <file>:print gtkpod hash for file\n"));
>    locale_fprintf(fp, _("  -m path:      define the mountpoint of your
> iPod\n")); locale_fprintf(fp, _("  --mountpoint: same as '-m'.\n"));
> -  locale_fprintf(fp, _("  -a:           import database automatically
> after start.\n")); -  locale_fprintf(fp, _("  --auto:       same as
> '-a'.\n"));
>  }
>
>  /* Parse commandline based options */
>
> You seems to have commit rights in the upstream repository, care to apply
> that?
>
> Gruesse,

I will when I have some time to spare on gtkpod upstream. Thanks for the diff!

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to