On Wed, Feb 13, 2008 at 02:50:34PM +0100, Michael Banck wrote: > The openldap2.3 build aborted on the hurd-i386 buildd. I wanted to > finish it manually, but saw that it re-ran autogen, then configure and > make depend and subsequently seemed to build a lot of stuff all over > again.
> I tracked this down to the $(builddir)/Makefile rule depending on the > PHONY patch target, and make apparently thinks it needs to run that > (which is a no-op, as the implementation of the patch target in > quilt.make depends on debian/stamp-patched which exists) and > subsequently $(builddir)/Makefile again, even though that file > exists. > Making $(builddir)/Makefile depend on debian/stamp-patched instead seems > to do what is expected (i.e., run make -C $(builddir) directly), patch > attached. This has the possible downside that it exposes a more or less > internal implementation detail of quilt.make (OTOH one could argue > Debian/Ubuntu should standardize on those debian/rules targets and > stamp-files anyway...) This looks reasonable to me, and indeed I've run into this same problem. Russ, you added the current dependency on the .PHONY target, can you think of any reason that depending on debian/stamp-patched instead would be wrong? -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer http://www.debian.org/ [EMAIL PROTECTED] [EMAIL PROTECTED] -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
