"Adam D. Barratt" <[EMAIL PROTECTED]> writes:

> As discussed recently, please find attached a patch (against lintian and
> devscripts SVN) to checks/scripts that adds the bashism tests that
> devscripts's checkbashisms performs but lintian does not.

Thank you!  You beat me to doing the merger.  One question, though:

> +               'echo\s+-[e]',               # echo -e
> +               'exec\s+-[acl]',             # exec -c/-l/-a name
> +               '\blet\s',                   # let ...

Shouldn't these be prefixed with (^|\s+) instead of \b or nothing to not
catch things like "echo echo -e" (as odd as that might be)?  We do run the
risk of missing cases where people put the statement on the same line as
an if statement or the like, but I think it makes sense to err on the side
of conservatism.

-- 
Russ Allbery ([EMAIL PROTECTED])               <http://www.eyrie.org/~eagle/>



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to