Bastian Kleineidam wrote:
> mr uses chdir() to change the working directory to each repository it
> works on. However when a skip test is defined rcs_test() is called
> before chdir(), and then the test for git repositories fails (since
> "git config" checks that ".git" is in the current working directory).

Skip tests need to be able to skip checking out a repository, at which
point the directory doesn't exist to chdir to.

The rcs tests have to be written to test the directory in MR_REPO, *not*
the current directory.

I think it would probably help if you show me an example of mr doing
something wrong. Are you perhaps using the new git-svn include file? It
looks like that file's version of git_test doesn't make git config use
MR_REPO.

> Attached is a patch that moves the chdir() call before the skip test
> detection. This resolved the error for me.

That will break all checkouts.

-- 
see shy jo

Attachment: signature.asc
Description: Digital signature

Reply via email to