Package: googleearth-package
Version: 0.4.3
Severity: normal
Tags: patch

Hi,

the make-googleearth-package script generates an invalid .desktop file.
In particular:
- "Encoding" is deprecated, so can be removed
- "MultipleArgs" does not exist
- "Categories" is a list of strings, so it needs to end with the
  separator (';'); furthermore, the 'Application' category is deprecated
- "MimeType" is a list of strings, so it needs to end with the separator
  )';').

Attached there is a patch that solves all the issues.

Reference:
- 
http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-1.0.html

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (850, 'testing'), (800, 'unstable'), (750, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.22-3-amd64 (SMP w/2 CPU cores)
Locale: LANG=it_IT.UTF-8, LC_CTYPE=it_IT.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages googleearth-package depends on:
ii  bzip2                        1.0.4-2     high-quality block-sorting file co
ii  curl                         7.17.1-1+b1 Get a file from an HTTP, HTTPS or 
ii  dpkg-dev                     1.14.15     package building tools for Debian
ii  fakeroot                     1.9         Gives a fake root environment
ii  file                         4.23-1      Determines file type using "magic"
ii  wget                         1.10.2-3    retrieves files from the web
ii  x11-common                   1:7.2-5     X Window System (X.Org) infrastruc

googleearth-package recommends no packages.

-- no debconf information
--- make-googleearth-package.orig       2008-01-26 15:40:39.000000000 +0100
+++ make-googleearth-package    2008-01-26 15:40:22.000000000 +0100
@@ -152,17 +152,15 @@
 function make_fdo_desktop_entry() {
   cat <<EOF >googleearth.desktop
 [Desktop Entry]
-Encoding=UTF-8
 Name=Google Earth
 GenericName=3D planet viewer
 Comment=Explore, search and discover the planet
 Exec=googleearth %f
 Terminal=false
-MultipleArgs=false
 Type=Application
 Icon=/usr/lib/googleearth/resources/googleearth-icon.png
-Categories=Application;Network
-MimeType=application/vnd.google-earth.kml+xml;application/vnd.google-earth.kmz;application/earthviewer;application/keyhole
+Categories=Network;
+MimeType=application/vnd.google-earth.kml+xml;application/vnd.google-earth.kmz;application/earthviewer;application/keyhole;
 EOF
 }
 

Reply via email to