Package: ucf
Version: 3.004
Severity: normal
Tags: patch

Hi,

ucfq /path/to/file never gives any output. Consider:

sid% ucfq tex-common
Configuration file                            Package             Exists
Changed
/etc/texmf/texmf.d/05TeXMF.cnf                tex-common          Yes
/etc/texmf/texmf.d/15Plain.cnf                tex-common          Yes
/etc/texmf/texmf.d/45TeXinputs.cnf            tex-common          Yes
/etc/texmf/texmf.d/55Fonts.cnf                tex-common          Yes
/etc/texmf/texmf.d/65BibTeX.cnf               tex-common          Yes
/etc/texmf/texmf.d/75DviPS.cnf                tex-common          Yes
/etc/texmf/texmf.d/85Misc.cnf                 tex-common          Yes
/etc/texmf/texmf.d/90TeXDoc.cnf               tex-common          Yes
/etc/texmf/texmf.d/95NonPath.cnf              tex-common          Yes
/etc/texmf/updmap.d/00updmap.cfg              tex-common          Yes
sid% ucfq /etc/texmf/texmf.d/05TeXMF.cnf
sid% ucfq /etc/texmf/texmf.d/15Plain.cnf 
sid% 

It looks like the problem is that ^/ is matched twice with the global
option (m//g) on the filename in ucf::process(), so the second one fails
looking for the next match.

I don't see the need for global match here, and removing the /g fixes
this for me. Proposed patch attached, sorry if I'm missing something.

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.18-5-xen-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=fi_FI.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages ucf depends on:
ii  cdebconf [debconf-2.0]        0.126      Debian Configuration Management Sy
ii  coreutils                     5.97-5.7   The GNU core utilities
ii  debconf [debconf-2.0]         1.5.18     Debian configuration management sy

Versions of packages ucf recommends:
ii  debconf-utils                 1.5.18     debconf utilities

-- debconf information excluded
>From 8c67efe810a5968929fd3fd42bc95c0a386300ff Mon Sep 17 00:00:00 2001
From: Niko Tyni <[EMAIL PROTECTED]>
Date: Tue, 15 Jan 2008 13:42:38 +0200
Subject: [PATCH] global matching is not wanted here

---
 ucfq |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/ucfq b/ucfq
index 42fa77a..06f2dea 100755
--- a/ucfq
+++ b/ucfq
@@ -270,9 +270,9 @@ sub process {
   }
   for (keys %{$this->{configs}}) {
     warn "Need a fully qualified path name for config file \"$_\"\n"
-      unless m,^/,g;
+      unless m,^/,;
     # Don't die for etch
-    exit 0 unless m,^/,g;
+    exit 0 unless m,^/,;
     my $file = conffile->new('Name' => "$_");
     $this->{file_list}->element($_, $file);
   }
-- 
1.5.3.8

Reply via email to