On Mon 31 Dec 2007, Petter Reinholdtsen wrote: > > When testing dependency based boot sequencing, I discovered a minor > bug in the init.d script for rsync. The start and stop dependencies > are not optimal. The script should start after file systems and > syslog is available, stop before file systems are umounted (and > shortly before that, when all remaining processes killed by the > sendsigs script). This patch solve the issue:
OK, thanks for looking into this... One question though: > --- rsync-2.6.9.orig/debian/init.d 2007-12-31 12:27:35.000000000 +0100 > +++ rsync-2.6.9/debian/init.d 2007-12-31 12:33:07.000000000 +0100 > @@ -2,10 +2,9 @@ > > ### BEGIN INIT INFO > # Provides: rsyncd > -# Required-Start: $network > -# Required-Stop: $syslog > -# Should-Start: $named $syslog > -# Should-Stop: $syslog network > +# Required-Start: $remote_fs $syslog > +# Required-Stop: $remote_fs $syslog Why the $remote_fs, instead of $network? Rsync should _not_ be used with network filesystems, as data is transferred excessively over the network in that case. Additionally, you may configure rsync to use a logfile instead of using syslog, which is why I put $syslog in the "Should-*" parts instead of the "Required-*" parts. > +# Should-Start: $named > # Default-Start: 2 3 4 5 > # Default-Stop: 0 1 6 > # Short-Description: fast remote file copy program daemon > > As the stop script do not seem to do anything except killing the > daemon, that task might be better left to the sendsigs script in > runlevel 0 and 6. If this is indeed the case, I recommend removing 0 > and 6 from the Default-Stop list. By the same token, if syslog should be available when rsync is running, doesn't it make sense to then stop rsync before stopping syslog? thanks, Paul Slootman -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
