Hi Niko,
this should fix it:
Index: smokeping-zoom.js
===================================================================
--- smokeping-zoom.js (revision 910)
+++ smokeping-zoom.js (working copy)
@@ -79,8 +79,9 @@
window,
'load',
function() {
- myCropper = new Cropper.Img(
- 'zoom',
+ if ( $('zoom') != null ){
+ myCropper = new Cropper.Img(
+ 'zoom',
{
minHeight:
$('zoom').getDimensions().height,
maxHeight:
$('zoom').getDimensions().height,
@@ -88,5 +89,6 @@
}
)
}
+ }
);
cheers
tobi
Friday Niko Tyni wrote:
> On Wed, Dec 19, 2007 at 10:43:31AM -0400, Ben Armstrong wrote:
> > Package: smokeping
> > Version: 2.2.7-1
> > Severity: minor
>
> > Firebug tells me:
> >
> > $("zoom") has no properties
> >
> > at line 85 in smokeping-zoom.js
> >
> > This happens whenever I view a page without the javascript zoom
> > widget. This could be handled by testing for the presence of the
> > element and only execute these lines if the element is present, or
> > better yet, simply do not include smokeping-zoom.js on this page
> > if it is not used.
>
> Hi,
>
> thanks for your report. I'm forwarding it to Tobias Oetiker, who wrote
> this part of the code.
>
> Tobi, please keep [EMAIL PROTECTED] Cc'd.
>
> Cheers,
>
--
Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten
http://it.oetiker.ch [EMAIL PROTECTED] ++41 62 213 9902
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
