Bastian Blank wrote:
On Sat, Dec 15, 2007 at 07:40:07PM +0100, Guido Guenther wrote:
for your convenience I attach Richard's patch directly. It simply
installs the necessary headers so we're able to enable xen support in
libvirt for the default builds. Please apply.

libvirt redefines several parts of this headers. So they can include the
missing pieces also.

We include redefinitions in a very few places, particularly where the Xen headers used to include definitions which have since been removed. Last week a bug was raised about this, I'm not sure if this is what you're referring to:

https://www.redhat.com/archives/libvir-list/2007-December/msg00251.html

The greater point is that the headers which this patch includes are part of the public Xen API, and these header files are normally exported. Except that in both Debian and Fedora, because of the specific way that Debian and Fedora packaging call into a part of the Xen system of makefiles, they don't get exported. Specifically:

  $(MAKE) -C $(SOURCE_DIR)/tools install [...]

Debian only do the 'make install' in a subdirectory. If Debian did a normal 'make install', these headers would be installed, but there are other drawbacks to doing that, so exporting the headers by hand is the next best thing.

Rich.

--
Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom.  Registered in
England and Wales under Company Registration No. 03798903

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

Reply via email to