Hi Andreas, On Fri, Dec 07, 2007 at 06:57:13PM +0100, Andreas Metzler wrote: > I had seen that patch in Ubuntu but had disregarded it. I am not > perfectly sure about ionice syntax, but I think that > IONICE_CLASS 3 idle seems to be perfect for locate.
I think the original author of the Ubuntu patch hadn't realized that setting the IONICE_CLASS 3 would still work, even if the user ended up non-root. When I was merging changes, I pondered totally dropping the patch, but realized that it did offer people the ability to tune the ioniceness, if they wanted. As such, I figured I'd offer it as a possible feature. If you don't think that's useful, I am easily convinced. :) > Why are you defaulting to IONICE_CLASS 2 instead of 3? How is this > better? Is there some policy I am not aware of? This was just because other tools that are starting to use ionice aren't able to set IONICE_CLASS 3 (non-root stuff like tracker, beagle, etc), and I was just aiming for everything being at the same niceness. Again, not a giant reason. Again, if you don't think this is useful, I'm happy to drop the patch -- I just wanted to propose it. :) Thanks! -Kees -- Kees Cook @outflux.net -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
