From: Luca Falavigna <[EMAIL PROTECTED]>
To: Debian Bug Tracking System <[EMAIL PROTECTED]>
Subject: Bashism leads to FTBFS
Package: xorp
Version: 1.5~cvs.20070824-1
Severity: minor
Tags: patch
User: [EMAIL PROTECTED]
Usertags: origin-ubuntu hardy ubuntu-patch

Your package has a bashism in debian/rules which causes FTBFS on systems with /bin/sh linked to /bin/dash. Even if Debian does not seem affected, it could be worth adjust it for compatibility purposes.

Attached patch, taken from Ubuntu version, should implement this.

Thank you.
ÿþdiff -pruN 
1.5~cvs.20070824-1/debian/rules 
1.5~cvs.20070824-1ubuntu1/debian/rules

--- 1.5~cvs.20070824-1/debian/rules 
2007-11-24 13:14:06.000000000 +0000

+++ 
1.5~cvs.20070824-1ubuntu1/debian/rules   
2007-11-24 13:11:49.000000000 +0000

[EMAIL PROTECTED]@ -65,7 +65,7 [EMAIL PROTECTED]@ 
build-indep-stamp:

      dh_testdir

 

      # Add here commands to compile the 
indep part of the package.

-     pushd docs && $(MAKE) && popd

+     cd docs && $(MAKE) && cd $(CURDIR)

      touch [EMAIL PROTECTED]

 

 

[EMAIL PROTECTED]@ -73,7 +73,7 [EMAIL PROTECTED]@ clean:

      dh_testdir

      dh_testroot

      # Add here commands to clean up 
after the build process.

-     pushd docs ; $(MAKE) distclean || 
true ; popd

+     cd docs ; $(MAKE) distclean || true 
; cd $(CURDIR)

      -$(MAKE) distclean || true

 ifneq "$(wildcard 
/usr/share/misc/config.sub)" ""

      cp -f /usr/share/misc/config.sub 
config.sub

[EMAIL PROTECTED]@ -111,7 +111,7 [EMAIL PROTECTED]@ 
install-arch:

      # Binaries : 

      find debian/xorp/usr/lib/xorp/bin/ 
-type f -exec mv -v {} 
debian/xorp/usr/sbin/ \;

      mv debian/xorp/usr/bin/xorp_rtrmgr  
debian/xorp/usr/sbin/

-     pushd debian/xorp/usr/sbin/ && find 
-type f -exec ln -vsf /usr/sbin/{} 
../lib/xorp/bin/ \; && popd

+     cd debian/xorp/usr/sbin/ && find 
-type f -exec ln -vsf /usr/sbin/{} 
../lib/xorp/bin/ \; && cd $(CURDIR)

 

      # Config files : 

      cp debian/config.boot.small 
debian/xorp/etc/xorp/config.boot

Reply via email to