tags 451271 pending thanks On Mon, Nov 19, 2007 at 08:41:58PM -0500, Mathias Gug wrote:
> On Mon, Nov 19, 2007 at 12:06:58PM -0800, Steve Langasek wrote: > > On Wed, Nov 14, 2007 at 12:44:50PM -0500, Mathias Gug wrote: > > > I've attached a patch that sets a default value of MSHOME to the debconf > > > question asking for the workgroup. MSHOME is the default workgroup name > > > used in > > > Windows. > > In the Debian package, the default workgroup is set in the debian/smb.conf > > file. Is there a reason it should be set in the template instead? (Open > > question - there have been some issues with the current debconf code which > > I've meant to go back and fix, and maybe this takes care of it, but then we > > seem to have duplication of data between the two locations.) > If a question is asked, it may be better if a default value is already > provided (which is not the case now IIRC). OTOH if a default is set, the > current config script will drop the debconf priority to medium, which is > not seen by default during ubuntu install. I've confirmed that this gives the desired effect in all cases. Since the config script is initially run (with or without dpkg-preconfigure) before smb.conf exists on disk, the only way to prepopulate a value for the debconf question is by setting the default on the template itself, so this is precisely what we want; actually, the value in the template smb.conf itself hardly matters as a result of this, the one in the debconf template is the /only/ one we need to worry about. As for the debconf priority, making the priority variable obviously no longer makes sense. I think the right priority for this is "high", and I've just committed a change to that effect, because while WORKGROUP is the right default, it's obviously not a reasonable value for anyone who's going to join a domain. I'm open to arguments for making it medium instead of high, of course, but going by my own usage experience "high" seems to fit best. Cheers, -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. [EMAIL PROTECTED] http://www.debian.org/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
