Kilian Krause a écrit :
ok, let's start with the obvious. The Debian packaging of tsclient is supposed to be the debian/ dir only. I.e. if you have a new upstream source, there is no need to patch the full source to the new version and mail that as diff. You just include the new tarball version for that release in debian/changelog and make the neccessary adjustments in debian/. Most commonly it's a good idea to add a get-orig-source target for this - or to plain use it if it's there already. ;)
Duh. I didn't saw this target. I told you I wasn't familiar with CDBS ;)
For the "all in one" patch, I actually don't know why I did that. I should have known better. Of course a patch against the debian dir is the way to go.
I misread guidlines in /usr/share/doc/autotools-dev. Now that you point it to me, I can see that I should have paid more attention to the introduction ;)Second you included automake1.9 and autoconf in the Build-Deps. That generally is a *very good* indication for things that have gone utterly wrong. For a proper packaging you should not regenerate the configure during the build to keep a certain amount of reproducability. That's the reason there was a patch for that update to make the outcome rather predictable. Maintainer mode is for developers, not for packagers. ;)
Moreover if you drop patches, it's always nice to know why this is no longer needed (added included upstream for that reason).
Ok.
It is OK to me, except that I just saw a little UI problem in the patch. The remote drive mapping should be disabled in the UI when the selected protocol is not RDP. Attached is a svn diff that correct it.Thirdly, the SVN was a bit further, so your patch didn't really applycleanly. I have manually fixed that part.The result with some slight modifications to get the package mostly lintian clean I have put in SVN[1]. Can you verify this is the intended result so I can go and upload it? Thanks!
My friend should upgrade the sourceforge version shortly (it seems it is not possible to attach a new file if you are not the original submitter).
Thanks for educating me ;) -- Clément Hermann (nodens) - "L'air pur ? c'est pas en RL, ça ? c'est pas hors charte ?" Jean in L'Histoire des Pingouins, http://tnemeth.free.fr/fmbl/linuxsf/ Vous trouverez ma clef publique sur le serveur public pgp.mit.edu. Please find my public key on the public keyserver pgp.mit.edu.
tsclient.rev13401.diff
Description: application/pgp-encrypted
