Package: gdebi
Version: 0.2.4debian1
Severity: important
Tags: patch
Hi,
you don't call dh_installmime and dh_desktop with an appropriate timing:
before the dh_install call. The related debhelper scriptlets didn't get
included due to that, which means e.g. a missing update-mime call.
Please find attached a tiny patch to fix that, and the consequence on
the generated packages.
Filing as important since it is a violation of a “SHOULD” of the Policy,
although it violates a “MUST” of the MIME sub-policy.
Cheers,
--
Cyril Brulebois
--- gdebi-0.2.4debian1/debian/changelog 2007-04-24 21:41:28.000000000 +0200
+++ gdebi-0.2.4debian2/debian/changelog 2007-11-06 04:22:28.000000000 +0100
@@ -1,3 +1,9 @@
+gdebi (0.2.4debian2) unstable; urgency=low
+
+ * Move dh_installmime and dh_desktop calls after the dh_install one.
+
+ -- Cyril Brulebois <[EMAIL PROTECTED]> Tue, 06 Nov 2007 04:22:13 +0100
+
gdebi (0.2.4debian1) unstable; urgency=low
* updated to new upstream version
--- gdebi-0.2.4debian1/debian/rules 2007-04-24 21:18:16.000000000 +0200
+++ gdebi-0.2.4debian2/debian/rules 2007-11-06 04:22:51.000000000 +0100
@@ -70,8 +70,6 @@
# dh_installlogrotate
# dh_installemacsen
# dh_installpam
- dh_installmime
- dh_desktop
# dh_installinit
# dh_installcron
# dh_installinfo
@@ -90,6 +88,9 @@
dh_install -Xsite-packages/GDebi --list-missing
+ dh_installmime
+ dh_desktop
+
dh_link
# dh_strip
dh_compress
debdiff gdebi*changes outputs:
| Files in second .changes but not in first
| -----------------------------------------
| -rwxr-xr-x root/root DEBIAN/postrm
Comparing the DEBIAN part of both gdebi binaries:
| diff -ruN DEBIAN-1/postinst DEBIAN-2/postinst
| --- DEBIAN-1/postinst 2007-11-06 04:21:42.000000000 +0100
| +++ DEBIAN-2/postinst 2007-11-06 04:23:30.000000000 +0100
| @@ -1,5 +1,15 @@
| #!/bin/sh
| set -e
| +# Automatically added by dh_installmime
| +if [ "$1" = "configure" ] && [ -x "`which update-mime-database 2>/dev/null`"
]; then
| + update-mime-database /usr/share/mime
| +fi
| +# End automatically added section
| +# Automatically added by dh_desktop
| +if [ "$1" = "configure" ] && which update-desktop-database >/dev/null 2>&1 ;
then
| + update-desktop-database -q
| +fi
| +# End automatically added section
| # Automatically added by dh_pycentral
| if which pycentral >/dev/null 2>&1; then
| pycentral pkginstall gdebi
| diff -ruN DEBIAN-1/postrm DEBIAN-2/postrm
| --- DEBIAN-1/postrm 1970-01-01 01:00:00.000000000 +0100
| +++ DEBIAN-2/postrm 2007-11-06 04:23:30.000000000 +0100
| @@ -0,0 +1,12 @@
| +#!/bin/sh
| +set -e
| +# Automatically added by dh_installmime
| +if [ -x "`which update-mime-database 2>/dev/null`" ]; then
| + update-mime-database /usr/share/mime
| +fi
| +# End automatically added section
| +# Automatically added by dh_desktop
| +if [ "$1" = "remove" ] && which update-desktop-database >/dev/null 2>&1 ;
then
| + update-desktop-database -q
| +fi
| +# End automatically added section
