Package: abcde
Severity: wishlist
The following patch from Ubuntu enables m4a tagging. It
enables code that is already there, however upstream
disabled it for a reason, so the merits of this patch
could be debated.
I am just relaying the patch, for more information
see https://bugs.launchpad.net/ubuntu/+source/abcde/+bug/138367
Thanks,
James
--- 2.3.99.6-1/abcde 2006-08-05 20:14:00.000000000 +0100
+++ 2.3.99.6-1ubuntu2/abcde 2007-10-18 16:24:45.000000000 +0100
@@ -1070,8 +1070,8 @@ do_encode ()
esac
COMMENT="--comment \"$COMMENT\""
fi
- # Quick hack to avoid tagging Ogg/Speex, since
there is no other way to tag than inline tagging
- if [ ! "$DOTAG" = "y" ]; then
+ # Tag the file at encode time, as it can't be
done after encoding.
+ if [ "$DOTAG" = "y" ]; then
$RUN_COMMAND nice $EFFECTIVE_NICE
$SPEEXENCODER $SPEEXENCODEROPTS --author "$TRACKARTIST" --title "$TRACKNAME"
"$COMMENT" "$IN" "$OUT"
else
$RUN_COMMAND nice $EFFECTIVE_NICE
$SPEEXENCODER $SPEEXENCODEROPTS "$IN" "$OUT"
@@ -1087,8 +1087,8 @@ do_encode ()
$RUN_COMMAND nice $EFFECTIVE_NICE $MPPENCODER
$MPPENCODEROPTS --artist "$TRACKARTIST" --album "$DALBUM" --title "$TRACKNAME"
--track "$1" --genre "$CDGENRE" --year "$CDYEAR" --comment "$COMMENT" "$IN"
"$OUT"
;;
m4a)
- # Quick hack to avoid tagging Ogg/Speex, since
there is no other way to tag than inline tagging
- if [ ! "$DOTAG" = "y" ]; then
+ # Tag the file at encode time, as it can't be
done after encoding.
+ if [ "$DOTAG" = "y" ]; then
$RUN_COMMAND nice $EFFECTIVE_NICE
$AACENCODER $AACENCODEROPTS --artist "$TRACKARTIST" --album "$DALBUM" --title
"$TRACKNAME" --track "$1" --genre "$CDGENRE" --year "$CDYEAR" --comment
"$COMMENT" -o "$OUT" "$IN"
else
