Hello! On Wed, 03 Oct 2007 02:53:21 +0200, Alberto Bertogli wrote: > On Mon, Oct 01, 2007 at 01:46:23PM +0200, Luca Capello wrote: >> Cc:ing upstream author, since this bug is clearly upstream and I'd >> like his opinion about my patch. > > In the future, please attach the patches uncompressed and inline. It > makes me able to comment on them inside the mail.
Even if I don't like inline patches [1], the next time I'll do as you prefer. >> On Tue, 21 Nov 2006 20:25:59 +0100, Philipp Kern wrote: >>> Instead it should prepend the path to the variable. >> >> Or, better, use a less generic name. > > That would have been nice, but sadly it breaks backwards > compatibility and I don't think it's worth it. On the contrary, I think it's worth it. One way is to move the change into two different releases: 1) the first release adds the new /etc/darcsweb.conf (or, which I like less, /etc/darcswebconf.py), which is preferred against /etc/darcsweb/config.py. A note is added in the NEWS or README files, so the users are clearly advised. 2) the second release removes /etc/darcsweb/config.py The main reason against the change is if /etc/darcsweb/ is intended to store other than a single file, config.py, which doesn't seem the case ATM. >> And while we're at here, I'd suggest to move the configuration to >> /etc/darcswebconf.py (even if the best would be >> /etc/darcsweb.conf), since AFAIK /etc/darcsweb/ contains config.py >> only. Upstream patch attached. > > Maybe a better solution that doesn't breaks backward compatibility > is to add /etc/darcsweb at the second place in sys.path. I don't know anything about python, but what if the first place in sys.path contains a config.py? The problem should be the same :-( Thx, bye, Gismo / Luca Footnotes: [1] because they waste space (yes, I'm a paranoid) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
