Package: et131x-source
Version: 1.2.3-4
Severity: wishlist

*** Please type your report below this line ***

Due to "mm: Remove slab destructors from kmem_cache_create()."
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=20c2df83d25c6a95affe6157a4c9cac4cf5ffaac
et131x-source fails to build against kernel 2.6.23.
        # Build the module
        /usr/bin/make KERNEL_SRC=/tmp/pkg/linux 
KERNEL_VER=2.6.23-rc9-git2-slh64-smp-1 KERNEL_DIR=/tmp/pkg/linux
        make[4]: Entering directory `/tmp/pkg/modules/et131x'
        #@/usr/bin/make -C /tmp/pkg/linux M=/tmp/pkg/modules/et131x modules
        make[5]: Entering directory `/tmp/pkg/linux-2.6.23-rc9-git2-slh64-smp-1'
          CC [M]  /tmp/pkg/modules/et131x/et131x_main.o
          CC [M]  /tmp/pkg/modules/et131x/et131x_initpci.o
          CC [M]  /tmp/pkg/modules/et131x/et131x_isr.o
        /tmp/pkg/modules/et131x/et131x_isr.c: In function 'et131x_isr_handler':
        /tmp/pkg/modules/et131x/et131x_isr.c:535: warning: cast from pointer to 
integer of different size
        /tmp/pkg/modules/et131x/et131x_isr.c:540: warning: cast from pointer to 
integer of different size
          CC [M]  /tmp/pkg/modules/et131x/et131x_netdev.o
        /tmp/pkg/modules/et131x/et131x_netdev.c: In function 'et131x_open':
        /tmp/pkg/modules/et131x/et131x_netdev.c:461: warning: 
'deprecated_irq_flag' is deprecated (declared at include/linux/interrupt.h:64)
        /tmp/pkg/modules/et131x/et131x_netdev.c:461: warning: passing argument 
2 of 'request_irq' from incompatible pointer type
        /tmp/pkg/modules/et131x/et131x_netdev.c: In function 
'et131x_set_mac_addr':
        /tmp/pkg/modules/et131x/et131x_netdev.c:1336: warning: ISO C90 forbids 
mixed declarations and code
          CC [M]  /tmp/pkg/modules/et131x/et131x_supp.o
          CC [M]  /tmp/pkg/modules/et131x/et131x_config.o
          CC [M]  /tmp/pkg/modules/et131x/et131x_debug.o
          CC [M]  /tmp/pkg/modules/et131x/ET1310_jagcore.o
          CC [M]  /tmp/pkg/modules/et131x/ET1310_tx.o
          CC [M]  /tmp/pkg/modules/et131x/ET1310_rx.o
        /tmp/pkg/modules/et131x/ET1310_rx.c: In function 
'et131x_rx_dma_memory_alloc':
        /tmp/pkg/modules/et131x/ET1310_rx.c:536: error: too many arguments to 
function 'kmem_cache_create'
        /tmp/pkg/modules/et131x/ET1310_rx.c: In function 'nic_rx_pkts':
        /tmp/pkg/modules/et131x/ET1310_rx.c:1670: warning: unused variable 
'vlan_tag'
        make[6]: *** [/tmp/pkg/modules/et131x/ET1310_rx.o] Error 1
        make[5]: *** [_module_/tmp/pkg/modules/et131x] Error 2
        make[5]: Leaving directory `/tmp/pkg/linux-2.6.23-rc9-git2-slh64-smp-1'
        make[4]: *** [modules] Error 2
        make[4]: Leaving directory `/tmp/pkg/modules/et131x'
        make[3]: *** [binary-modules] Error 2
        make[3]: Leaving directory `/tmp/pkg/modules/et131x'
        make[2]: *** [kdist_build] Error 2
        make[2]: Leaving directory `/tmp/pkg/modules/et131x'
        Module /tmp/pkg/modules/et131x failed.
        Perhaps /tmp/pkg/modules/et131x does not understand --rootcmd?
        If you see messages that indicate that it is not
        in fact being built as root, please file a bug
        against /tmp/pkg/modules/et131x.
        Hit return to Continue?

The attached patch fixes the issue (compile tested only).

Regards
        Stefan Lippers-Hollmann

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.23-rc9-git2-slh64-smp-2 (SMP w/2 CPU cores; PREEMPT)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages et131x-source depends on:
ii  bzip2                         1.0.3-7    high-quality block-sorting file co
ii  debhelper                     5.0.57     helper programs for debian/rules
ii  make                          3.81-3     The GNU version of the "make" util
ii  module-assistant              0.10.11    tool to make module package creati
ii  quilt                         0.46-4     Tool to work with series of patche

et131x-source recommends no packages.

-- no debconf information
--- ET1310_rx.c	2007-02-27 15:13:07.000000000 +0100
+++ ../../ET1310_rx.c	2007-09-03 23:08:27.000000000 +0200
@@ -532,7 +532,9 @@ int et131x_rx_dma_memory_alloc( ET131X_A
                                                 0,
                                                 SLAB_CACHE_DMA |
                                                 SLAB_HWCACHE_ALIGN, 
+#if (LINUX_VERSION_CODE < KERNEL_VERSION(2,6,23))
                                                 NULL,
+#endif
                                                 NULL );
 
 

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to