On Mon, Oct 01, 2007 at 04:55:23PM +0200, [EMAIL PROTECTED] wrote:
> Package: po-debconf
> Version: 1.0.10
> Severity: normal
> Tags: patch
> 
> Hello Nicolas,
> as promised here are my suggested changes. Some general remarks before:
> *)To indicate hyphes, I consequently used \\(hy (in the German version). 
>   You might consider using it in the English template as well.

I will check how it behaves after passing through pod2man.
In particular, in a manpage title (NAME section), a real minus sign is
needed (i.e. \- in roff).
I don't know how pod2man behaves when the pod contains \-, -, or \(hy, but
I prefer to keep the manpages as simple as possible.
(in roff, '-' is an hyphen, equivalent to '\(hy' and '\-' is the real
minus sign. In pod, I need to check)

Also, I don't know the rules for hyphens in English.
I would have use \(hy in  e.g. "non-null", but \(em in
"... - B<podebconf-report-po> - ..."


> *)I am not a native (but still good) English speaker. So after implemting
>   (most|all) changes, you might want to run the man pages past a second
>   (fluent|native) English speaker.

I will probably wait for a next release.
I don't really want to use the debian-l10n-english resource for these
manpages. I think the Smith reviews are more important.

> *)I noticed, that you cited other programms without specifing the man page
>   section. I did not comment this below, but I think it is custom to add
>   the man page section (at least for the first occurence in a man page).

I will change this.

> *)Please do *not* simply unfuzzy translations. At least for German, I tried
>   to faithfully reproduce the English original, even if I sometimes suggested
>   a change (because I thought you might mean something different). 

OK

> *)Please note that I did not look for punctuation, if you are interested,
>   I can provide you with web pages dedicated to proof reading punctuation.

If you have pointers, I'm interested.

I will send the updated PO tonight.

You can skip the end of the file. It is quite boring.
Thanks a lot for this review.

> Also please note, that several lines contain *multiple* changes.
> 
> -"Each input file is renamed with a C<.old> suffix, and new master file "
> +"Each input file receives an C<.old> suffix, and new master file "

Done

> -"overwrites the old one; it is identical to the master file except that an "
> +"overwrites the old one; it is identical to the previous master file except 
> that an "

Done

> -"into a temporary template file, which is passed as an argument of "
> -"B<debconf-gettextize>.  The following steps are then performed:"
> +"into a temporary template file, which is to B<debconf-gettextize> as an "
> "argument.  Then the following steps are performed:"

I've added a missing "passed".

> -msgid "Display a usage summary program and exit."
> +msgid "Display a usage summary for the program and exit."

Done

> -"Set directory for PO files.  Default is to search PO files in the F<po> "
> +"Set directory for PO files.  Default is to search for PO files in the F<po> 
> "

Done

> -"C<Multiselect>, because value has to be chosen amongst B<English> list of "
> +"C<Multiselect>, because a value has to be chosen amongst the B<English> 
> list of "

Done

> -"This program reads F<po/POTFILES.in> to find which master files are looked "
> -"at, then extract new gettext strings into F<po/templates.pot> and update 
> all "
> +"This program reads F<po/POTFILES.in> to determine which master files need 
> to "
> +"be processed, then extracts new gettext strings into F<po/templates.pot> 
> and "
> +"updates all "

Done

> -"directory, or in F<debian> or F<debian/po> subdirectories.  It is run by "
> +"directory, or in the F<debian> or F<debian/po> subdirectories.  It is run 
> by a"

Done

> -"variable must point to a filename containing the encoding map),"
> +"variable must point to a name of a file containing the encoding map)."

Done

> -"developer and/or translator to update PO files when English text is 
> modified "
> +"developer and/or translator to update PO files when the English text is 
> modified "

Done

> -"distribution with no notification to the Debian maintainer."
> +"distribution without a notification to the Debian maintainer."

Done

> -"Lines beginning with a number sign (C<#>) are comments in templates files, "
> -"they are useful to give hints to translators, and are discarded by "
> +"Lines beginning with a number sign (C<#>) are comments in templates files. "
> +"They are useful to give hints to translators, and are discarded by "

Done

> -"B<po2debconf>.  Special comments have been introduced in C<po-debconf> 1.0, 
> "
> -"they are in the form C<#flag:I<directive>>.  The C<#flag:partial> is the "
> +"B<po2debconf>.  Special comments have been introduced in C<po-debconf> 1.0. 
> "
> +"They are of the form C<#flag:I<directive>>.  The C<#flag:partial> is the "

Done

> -"is translated if all paragraphs are translated.  When a field succeeds "
> +"is translated if all paragraphs are translated.  When a field contains "

Done

> -"  #   Sharp is comment sign\n"
> +"  #   Number sign is comment sign\n"

Done

> -"output format.  It contains a single line, first field is output format "
> +"output format.  It contains a single line, the first field is the output 
> format "

Done

> "single line"
> "single line."

I changed the period to a colon.

> -"the B<dh_installdebconf> script (make sure to have a versionned build "
> +"the B<dh_installdebconf> script (make sure to have a versioned build "

I never know, and my dictionary does not recognize any of them.
Done anyway.

> -"The first one contains only the English text, and mark some fields to be "
> +"The first one contains only the English text, and contains marks to denote 
> some fields to be "

Done

> -"field.  (Note: with C<po-debconf> E<lt> 1.0, the comment was written only "
> +"field.  (Note: with C<po-debconf> E<lt> 1.0, the comment was printed only "

Done

> -"The example above has a comment without C<#flag:comment> directive, an "
> +"The example above has a comment without C<#flag:comment> directive, where 
> an "

Done

> -"e.g.  C<Description-de.ISO-8859-1> or C<Choices-ru.KOI8-R>.  By default "
> +"e.g. C<Description-de.ISO-8859-1> or C<Choices-ru.KOI8-R>.  By default "

Done

> -"(ie, the ones needing translator's attention because the original changed)"
> +"(i.e., the ones needing translator's attention because the original 
> changed)"

Done

> -"For the same reason, B<debconf-gettextize> can mark fuzzy text because of "
> +"For the same reason, B<debconf-gettextize> can mark text fuzzy because of "

Done

> -"considered, so you should make sure your source package do provide them."
> +"considered, so you should make sure your source package does provide them."

I simplified it to just "provides" instead of "does provide".

> -"maintainer as bug report of severity B<minor> with the B<patch> tag."
> +"maintainer as bug report of severity B<wishlist> with the B<patch> tag."

Done

> -"PO file.  If you want to check a translation in another language, you need "
> +"the PO file.  If you want to check a translation in another language, you 
> need "

Done

> -"strings are displayed instead of the localized ones.  You have then to "
> +"strings are displayed instead of the localized ones.  You then have to "

Done

> -"This program reads F<debian/po/*.po> to find which files contain fuzzy or "
> +"This program reads F<debian/po/*.po> to determine which files contain fuzzy 
> or "

Done

> -"translator requesting for updates.  The mail will contain the PO file which 
> "
> +"translator requesting updates.  The mail will contain the PO file which "

Done

> -"B<podebconf-report-po> can also be used to send call for translations to a "
> +"B<podebconf-report-po> can also be used to send a call for translations to 
> a "

Done

> -"Different template exist for translation update requests, request to send "
> +"Different templates exist for translation update requests, request to send "

Done

> -"updated PO files to a bug report (B<--submit>) or for call for translations 
> "
> +"updated PO files to a bug report (B<--submit>) or for calls for 
> translations "

Done

> -"Specify where are located the PO files.  By default, B<podebconf-report-po> 
> "
> +"Specify where the PO files are located.  By default, B<podebconf-report-po> 
> "

Done

> -"Specify a list of languages to restrict ending the notification only for "
> +"Specify a list of languages to restrict sending the notification only for "

Done

> -"these languages.  The list on languages is comma separated. The PO files "
> +"these languages.  The list of languages is comma separated. The PO files "

Done

> -"Lines starting by a pound sign (possibly preceded by spaces) are comments "
> +"Lines starting by a number sign (possibly preceded by spaces) are comments "

Done

> -"(i.e. follow the I<Reply-To> tag or sending the PO to a given bug report)."
> +"(e.g. follow the I<Reply-To> tag or sending the PO to a given bug report)."

Done

> -"Replaced by the statistics of the PO found in the PO directory (in the "
> +"Replaced by the statistics of the PO files found in the PO directory (in 
> the "
Done

Kind Regards,
-- 
Nekral



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to