On Wed, 2007-09-19 at 04:00 +0200, Samuel Thibault wrote: > Uh, the variable got pretty big. > > More formally, it's just a matter of, where %L is used, to also use > %l_%t.%c, %l.%c and %l_%t. >
OK. > > All things considered, maybe XFILESEARCHPATHDEFAULT could be set this > way instead, much more readable: > > XFILESEARCHPATHDEFAULT= > for i in "$(sysconfdir)" "$(datadir)" "$(libdir)"; do > for j in %N%C%S %N%S ; do > for k in %L/ %l_%t.%c/ %l.%c/ %l_%t/ %l/ "" ; do > > XFILESEARCHPATHDEFAULT="${XFILESEARCHPATHDEFAULT:+$XFILESEARCHPATHDEFAULT:}$i/X11/$k%T/$j" > done > done > done > > (which is actually the way I generated the bloat above) > (not tested within autoconf's quoting crazyness) > Yes, I think you're right, a structured formulation like this will make maintenance must easier. I'll see if I can get the equivalent running within the bounds of autoconf. I think what I'll do first is readapt the existing upstream code, to reproduce the existing variable but with better maintainability. Then when that's ready upstream, I'll make the Debian patch for the %t bits. I think I might keep the Debian patch explicit in debian/patches rather than applying it to the tree in our git, to emphasise that it's a Debian-only patch not appropriate for pushing back upstream. Drew -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]