forwarded 438499 [EMAIL PROTECTED] thanks Hi Eddy,
On Fri, Aug 17, 2007 at 03:55:31PM +0300, Eddy Petri??or wrote:
> In the contribs area of the package there is a nice collectd2html.pl
> script which assumes that the data is present in /var/lib/collectd and
> infers the hostname. All fine and dandy, but there is no way to
> override this. This is useful if one generates the data on a machine,
> but generates the graphs on another one.
>
> With the attached patch now is possible to specify a different host
> and/or a different directory for the data.
>
> The added options are '--host-is' and '--data-dir'.
>
> An invocation for a remote host whose rrd files have been placed in
> /var/tmp/collectd-remoteh looks like:
>
> collectd2html.pl --host-is=remoteh --data-dir=/var/tmp/collectd-remoteh
Thanks for your patch.
> Please send upstream and apply the patch in the next release of
> collectd.
I will wait for upstream to include it.
> --- collectd2html.pl.orig 2007-08-15 12:58:20.000000000 +0300
> +++ collectd2html.pl 2007-08-01 01:31:50.000000000 +0300
> @@ -1,4 +1,4 @@
> -#!/usr/bin/perl
> +#!/usr/bin/perl -w
>
>
> ################################################################################
> #
> @@ -36,12 +36,20 @@
> use strict;
> use Fatal qw(open close);
> use File::Basename;
> +use Getopt::Long qw(:config no_ignore_case bundling pass_through);
> +
> +my $DIR = "/var/lib/collectd";
> +my $HOST = "_UNDEFINED_";
I'd change this to "my $HOST = undef;".
> +
> +GetOptions (
> + "host-is=s" => \$HOST,
Imho "host=s" sounds a lot nicer :-)
> + "data-dir=s" => \$DIR
> +);
>
> -my $DIR = "/var/lib/collectd";
> my @COLORS = (0xff7777, 0x7777ff, 0x55ff55, 0xffcc77, 0xff77ff, 0x77ffff,
> 0xffff77, 0x55aaff);
> my @tmp = `/bin/hostname`; chomp(@tmp);
> -my $HOST = $tmp[0];
> +$HOST = $tmp[0] if ( $HOST =~ /_UNDEFINED_/ );
This would have to be "$HOST = $tmp[0] if (! defined $HOST);".
> my $IMG_DIR = "${HOST}.dir";
> my $HTML = "${HOST}.html";
Cheers,
Sebastian
--
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/
Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety. -- Benjamin Franklin
signature.asc
Description: Digital signature
