Package: phpbb2
Severity: important

The fix for bug #298580 seems to cause other problems for me.  It causes
errors that imply there is not a valid connection to the Postgres DB.  I 
noticed that the suggested patch is not quite the same as what is in
the phpbb2 package on Sarge.  Around line 91 we have:

        $encoding = ini_get ( 'default_charset' );
        pg_set_client_encoding ($this->db_connect_id, $encoding );

        $this->db_connect_id = ( $this->persistency ) ?
        pg_pconnect($this->connect_string) : pg_connect($this->connect_string);

But if I change it to this it makes the errors go away:

        $this->db_connect_id = ( $this->persistency ) ?
        pg_pconnect($this->connect_string) : pg_connect($this->connect_string);

        $encoding = ini_get ( 'default_charset' );
        pg_set_client_encoding ($this->db_connect_id, $encoding );

As you can see, the corrected version sets $this->db_connect_id before
calling pg_set_client_encoding() rather than after.  The system info 
below isn't accurate, the server is really running Sarge but I'm sending
this from my laptop.

-- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.11-1-686
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to