Package: laptop-detect
Version: 0.13.2
Severity: normal
Tags: patch

If the 'battery' module cannot be loaded (for instance, because it
does not exist), modprobe prints an error message indicating a fatal
failure ("FATAL: Module battery not found." on my system).  This can
be highly confusing, since laptop-detect is usually not called by the
user directly, but by some other program.  I saw it today when the xdm
maintainer scripts called laptop-detect (which they should not do, but
that is another story).  Of course, the error was not FATAL at all,
but it took me some time to realize that.

I propose to send modprobe's error messages to the bit bucket:

--- laptop-detect~      2007-07-17 05:22:27.000000000 +0200
+++ laptop-detect       2007-08-15 14:09:03.000000000 +0200
@@ -62,7 +62,7 @@
 fi
 
 # check for any ACPI batteries
-/sbin/modprobe battery || true
+/sbin/modprobe battery 2> /dev/null || true
 if [ -d /proc/acpi/battery ]; then
         results=`find /proc/acpi/battery -mindepth 1 -type d`
         if [ ! -z "$results" ]; then


-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.22.2
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages laptop-detect depends on:
ii  dmidecode                     2.9-1      Dump Desktop Management Interface 

laptop-detect recommends no packages.

-- no debconf information


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to