On Thu, Aug 09, 2007 at 07:22:36PM +0200, Evgeni Golov wrote:
> Yeah, I've just finished it. You can get it here:
> http://mentors.debian.net/debian/pool/main/t/tp-smapi/tp-smapi_0.32-1.dsc
>
> I think it is in good shape, builds fine here, so you are welcome to
> upload it, if you think it is okay too.
OK, I've a number of comments; here's round one:
- The _source_ package should not require kernel >= 2.6.19 in order to
build it. You will have to patch the Makefile to disable that check
when building the source package, but require it during the build of
the binary module packages.
- Your use of dpatch in the clean target is incorrect. It does not
allow for using a patched clean target within the Makefile. You
should have the following instead:
clean: clean-patched unpatch
clean-patched:
dh_testdir
dh_testroot
# etc....
$(MAKE) clean
dh_clean
- Also, on the same topic, you should not be ignoring the error when
the Makefile is not present -- it is not generated by autoconf, so
if it's missing there's a problem!
- Your second rules file is mis-named. It should probably be called
rules.modules since it is the debian/rules that used to build the
modules packages.
- It would be better if you could combine the two rules files that you
have so that there is only one place to make changes when necessary.
This shouldn't be too difficult since they will call different
targets depending on whether it's a source or module build.
- In both rules you don't export CFLAGS, so the noopt handling in
DEB_BUILD_OPTIONS will not make it to the actual compiles.
- In README.Debian, the third option should mention that the user will
need to manually compile the module -- not just unpack & install.
- The source package does not need to depend on make and bzip2,
mod-ass will pull those in for you.
- Using dpkg-divert is the wrong solution for kernel modules. You
should use the updates sub-dir to override the regular hdaps module.
See, for example, the alsa-source package.
- You should run `depmod -a` in the postinst and postrm scripts of the
module packages so that the modules can be found / removed by
modprobe.
- I'm not sure what debian/tp-smapi-source.links is supposed to
accomplish. Can you explain this to me.
Well, that's enough for one round. Let me know when you've fixed up and
uploaded a 0.32-2 package and I'll take another look.
--Joe
PS - You might want to take a look at the package I created for some
tips. It's available from http://people.debian.org/~jello/.
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
